Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: inject and optional decorators should allow key to be undefined #2329

Merged
merged 1 commit into from
Mar 22, 2023

Conversation

darkbasic
Copy link
Contributor

Description

Typescript 5 has tighter parameter decorator checking with --experimentalDecorators.
That means constructor parameter decorators should allow undefined as the type of key.

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Screenshots/Sandbox (if appropriate/relevant):

How Has This Been Tested?

I've tested patched graphql-modules in a project that makes use of TS5 and the Inject decorator.

Test Environment:

  • OS: Gentoo Linux ppc64le
  • graphql-modules: 2.1.1
  • NodeJS: v18.15.0

Checklist:

  • I have followed the CONTRIBUTING doc and the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests and linter rules pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Further comments

@changeset-bot
Copy link

changeset-bot bot commented Mar 22, 2023

🦋 Changeset detected

Latest commit: dc22011

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
graphql-modules Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dotansimha
Copy link
Collaborator

Thank you @darkbasic ❤️ I'm testing it on Hive with TS5 and will update soon!

@dotansimha dotansimha merged commit df7e2db into Urigo:master Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typescript 5 support
2 participants