Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mobile Menu Pull Request #15

Merged
merged 12 commits into from
Jun 27, 2023
Merged

Mobile Menu Pull Request #15

merged 12 commits into from
Jun 27, 2023

Conversation

Uzair-Manzoor
Copy link
Owner

This pull request has been created against the following implementations:

  • When the user clicks (or taps) the menu button, the mobile menu appears.
  • When the user clicks (or taps) the close (X) button, the mobile menu disappears.
  • When the user clicks (or taps) any of the mobile menu options, the mobile menu disappears.
  • When the user clicks (or taps) any of the mobile menu options, a correct part of the page is displayed.
  • Also added the linters as per Project requirements.

@Uzair-Manzoor Uzair-Manzoor temporarily deployed to github-pages June 26, 2023 22:28 — with GitHub Pages Inactive
Copy link

@Shedrack-Sunday Shedrack-Sunday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Uzair-Manzoor

While you made a great effort in this project, unfortunately, I cannot proceed to review your code.

Invalid Code Review Request 🔴

You have submitted a project, that does not have your partners commits as its a pair programming activity

Your Code Review Request will be marked as invalid in your Dashboard, so please submit a new one once you are ready 🙏

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

@Uzair-Manzoor Uzair-Manzoor temporarily deployed to github-pages June 26, 2023 23:26 — with GitHub Pages Inactive
@bhushan354 bhushan354 temporarily deployed to github-pages June 27, 2023 08:14 — with GitHub Pages Inactive
@Uzair-Manzoor Uzair-Manzoor temporarily deployed to github-pages June 27, 2023 08:26 — with GitHub Pages Inactive
Copy link

@abdallahmalima abdallahmalima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Uzair-Manzoor ,

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉

Highlights

  • On mobile hamburger is visible.✅
  • When the user clicks hamburger, menu appears.✅
  • When the user clicks close (X) button, menu disappears.✅

Optional suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@Uzair-Manzoor Uzair-Manzoor merged commit cf2a812 into main Jun 27, 2023
7 checks passed
@Uzair-Manzoor Uzair-Manzoor deleted the mobile-menu branch June 27, 2023 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants