Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mobile Menu Pull Request #15

Merged
merged 12 commits into from
Jun 27, 2023
Merged

Mobile Menu Pull Request #15

Show file tree
Hide file tree
Changes from 8 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
7fa4ee9
update&add eslinters to linters file
Uzair-Manzoor Jun 26, 2023
8a3512c
update package file
Uzair-Manzoor Jun 26, 2023
2b405cc
update resources folder
Uzair-Manzoor Jun 26, 2023
4b4b67c
add eslintrc file
Uzair-Manzoor Jun 26, 2023
b9c47d5
add JS file
Uzair-Manzoor Jun 26, 2023
47fd886
update html file
Uzair-Manzoor Jun 26, 2023
9750859
update css file
Uzair-Manzoor Jun 26, 2023
e84a114
update linters file
Uzair-Manzoor Jun 26, 2023
8df314f
update html file
Uzair-Manzoor Jun 26, 2023
79baeaa
update css file
Uzair-Manzoor Jun 26, 2023
a101da0
Update script.js
bhushan354 Jun 27, 2023
c8cc1e3
update js file
Uzair-Manzoor Jun 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions .eslintrc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
{
"env": {
"browser": true,
"es6": true,
"jest": true
},
"parser": "babel-eslint",
"parserOptions": {
"ecmaVersion": 2018,
"sourceType": "module"
},
"extends": ["airbnb-base"],
"rules": {
"no-shadow": "off",
"no-param-reassign": "off",
"eol-last": "off",
"import/extensions": [ 1, {
"js": "always", "json": "always"
}]
},
"ignorePatterns": [
"dist/",
"build/"
]
}
18 changes: 16 additions & 2 deletions .github/workflows/linters.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ jobs:
# - name: Setup Webhint
# run: |
# npm install --save-dev hint@7.x
# [ -f .hintrc ] || wget https://raw.githubusercontent.com/microverseinc/linters-config/master/html-css/.hintrc
# [ -f .hintrc ] || wget https://raw.githubusercontent.com/microverseinc/linters-config/master/html-css-js/.hintrc
# - name: Webhint Report
# run: npx hint .
stylelint:
Expand All @@ -43,9 +43,23 @@ jobs:
- name: Setup Stylelint
run: |
npm install --save-dev stylelint@13.x stylelint-scss@3.x stylelint-config-standard@21.x stylelint-csstree-validator@1.x
[ -f .stylelintrc.json ] || wget https://raw.githubusercontent.com/microverseinc/linters-config/master/html-css/.stylelintrc.json
[ -f .stylelintrc.json ] || wget https://raw.githubusercontent.com/microverseinc/linters-config/master/html-css-js/.stylelintrc.json
- name: Stylelint Report
run: npx stylelint "**/*.{css,scss}"
eslint:
name: ESLint
runs-on: ubuntu-22.04
steps:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
with:
node-version: "18.x"
- name: Setup ESLint
run: |
npm install --save-dev eslint@7.x eslint-config-airbnb-base@14.x eslint-plugin-import@2.x babel-eslint@10.x
[ -f .eslintrc.json ] || wget https://raw.githubusercontent.com/microverseinc/linters-config/master/html-css-js/.eslintrc.json
- name: ESLint Report
run: npx eslint .
nodechecker:
name: node_modules checker
runs-on: ubuntu-22.04
Expand Down
79 changes: 41 additions & 38 deletions index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,44 +4,46 @@
<meta charset="UTF-8">
<meta http-equiv="X-UA-Compatible" content="IE=edge">
<meta name="viewport" content="width=device-width, initial-scale=1.0">
<title>Personal Portfolio</title>
<title>Uzair's Portfolio</title>
<link rel="stylesheet" href="style.css">
</head>
<body>
<header class="header">
<nav class="header-nav">
<div>
<a href="#"><img src="resources/images/Logo.png" alt="my logo"></a>
</div>
<div class="header-manu">
<img class="manu-icon" src="resources/icon/menu.png" alt="menu icon">
</div>
<ul class="nav-items">
<li class="nav-item">
<a class="nav-item-action" href="#portfolio">Portfolio</a>
</li>
<li class="nav-item">
<a class="nav-item-action" href="#about">About</a>
</li>
<li class="nav-item">
<a class="nav-item-action" href="#contact">Contact</a>
</li>
</ul>
<ul class="mobile-nav-items">
<li class="nav-item">
<a class="nav-item-action" href="#portfolio">Portfolio</a>
</li>
<li class="nav-item">
<a class="nav-item-action" href="#about">About</a>
</li>
<li class="nav-item">
<a class="nav-item-action" href="#contact">Contact</a>
</li>
</ul>
<header class="header">
<nav class="header-nav">
<div class="header-logo">
<a class="blue" href="#">Uzair Manzoor</a>
</div>
<div class="header-manu">
<img class="manu-icon" src="resources/icon/menu.png" onclick="openmenu()" alt="menu"/>
</div>
<ul class="nav-items">
<li class="nav-item">
<a class="nav-item-action" href="#portfolio">Portfolio</a>
</li>
<li class="nav-item">
<a class="nav-item-action" href="#about">About</a>
</li>
<li class="nav-item">
<a class="nav-item-action" href="#contact">Contact</a>
</li>
</ul>
<ul class="mobile-nav-items" id="mobile-nav-items">
<span class="toggle-cross">
<img src="resources/icon/cross-icon-01.png" onclick="closemenu()" alt="X"/>
</span>
<li class="nav-item" onclick="closemenu()">
<a id="m-nav" class="nav-item-action" href="#portfolio">Portfolio</a>
</li>
<li class="nav-item" onclick="closemenu()">
<a id="m-nav" class="nav-item-action" href="#about">About</a>
</li>
<li class="nav-item" onclick="closemenu()">
<a id="m-nav" class="nav-item-action" href="#contact">Contact</a>
</li>
</ul>
</nav>
</header>
</header>
<main>
<!-- Banner -->
<section class="headline-container">
<article class="article">
<div class="article-item1">
Expand Down Expand Up @@ -83,7 +85,7 @@ <h3 class="scale-para"><a class="social-title" href="#">LET'S CONNECT</a></h3>
</article>
</section>
<!-- work section -->
<section class="work-section">
<section class="work-section" id="portfolio">
<div class="work-card">
<div class="work-preview">
<img class="project-img" src="resources/images/Snapshoot Portfolio 5.jpg" alt="Project 1">
Expand Down Expand Up @@ -173,7 +175,7 @@ <h2 class="work-title">Multi-Post Stories</h2>
</div>
</div>
</section>
<section class="about">
<section class="about" id="about">
<div class="about-myself">
<h2 class="headline-title">About Myself</h2>
<p class="headline-content">
Expand Down Expand Up @@ -262,10 +264,10 @@ <h3 class="sub-title">
</ul>
</div>
</section>
<section class="contact_form">
<section class="contact_form" id="contact">
<div class="contact_container">
<h2 class="title">Contact me</h2>
<p class="contact_form_des">
<p class="form_dis">
If you have an application you are interested in developing, a
feature that you need built or a project that needs coding. I'd
love to help with it
Expand Down Expand Up @@ -307,6 +309,7 @@ <h2 class="title">Contact me</h2>
</form>
</div>
</section>
</main>
</main>
<script src="script.js"></script>
</body>
</html>
Loading