Comment counter #34
Merged
Comment counter #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
usamamaliq
requested changes
Nov 24, 2022
There was a problem hiding this comment.
Hi @V-Blaze,
Changes Required♻️
Highlights 🥇
✔️ Following GitHub Flow
✔️ Descriptive PR Summary
✔️ Descriptive PR Title
Good job on implementing the comments counter. There are some issues that you need to work on before we can move forward
- There are some items where when the name size increases all the pop-up section gets out of proportion. Kindly fix this to have a similar popup style for every item.
README.md
Outdated
| ## 📝 License | ||
|
|
||
| - This project is [MIT](https://github.com/V-Blaze/FOODHUB.git/blob/main/LICENSE) licensed. |
There was a problem hiding this comment.
The license file is not linked properly. Clicking the link gives an error. You can fix this by renaming the "LICENSE" file to "LICENSE.md" and updating the link in the readme as well.
usamamaliq
approved these changes
Nov 24, 2022
There was a problem hiding this comment.
Hi @V-Blaze,
STATUS: APPROVED ✔️ ✔️
Your project is complete! There is nothing else to say other than... it's time to merge it
Congratulations and good job! 🎉
approved
Highlights
- Good job fixing the required changes 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this pull request, below are the Significant changes: