Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #580 Gatwick (EGKK) SID redesignation #588

Merged
merged 6 commits into from
Mar 29, 2017

Conversation

agentsquash
Copy link
Collaborator

@agentsquash agentsquash commented Mar 4, 2017

Summary of changes

Re-routed and re-designated Gatwick eastbound departures on easterly operations.

@agentsquash agentsquash changed the title Gatwick (EGKK) SID redesignation Fixes #580 Gatwick (EGKK) SID redesignation Mar 4, 2017
@cpawley
Copy link
Contributor

cpawley commented Mar 5, 2017

Changelog pls! <3

@cpawley cpawley added this to the 1704 milestone Mar 5, 2017
@cpawley cpawley added the airac AIP-related changes label Mar 5, 2017
Copy link
Contributor

@hazzas-99 hazzas-99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the comment regarding historical TIGER SIDs.

@@ -56,10 +59,6 @@ SID:EGKK:08L:SFD9W:D076C D344U D344M D344G SFD
SID:EGKK:26L:TIGER1X:KKW04 KKS06 KKS09 KKS14 MAY KKS36 LAM
SID:EGKK:26L:TIGER3M:D260C D284M D284I MAY TIGER LAM
SID:EGKK:26R:TIGER3V:D262C D284M D284I MAY TIGER LAM
SID:EGKK:26L:#TIGER2M:IWW23 MAY13 MAY9 MAY TIGER LAM
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check whether IWW23, MAY13 and MAY9 appear in any other locations after this deletion. If they don't, I would remove them from FIXES_General RNAV.txt. If I hadn't scrolled down to the bottom, I wouldn't have noticed this... that's why you need to detail full changes made or, ideally, make issues/pull requests relate to individual changes (not individual files for the same issue obviously).

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have verified against the FIXES_General RNAV.txt and these fixes are no longer used.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As such, @agentsquash, could you initiate their removal?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has been done.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@agentsquash Those changes are not visible in the PR could you check you made them in the right branch?

@cpawley
Copy link
Contributor

cpawley commented Mar 16, 2017

Can you explain the rationale for keeping BIG1Z, ODVIG1Z and CLN1Z?

Changelog still needs these changes added.

@cpawley cpawley merged commit 613a187 into VATSIM-UK:master Mar 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
airac AIP-related changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants