-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Befaco A*B+C #21
Comments
Ah yeah good catch. The issue is here, were the normalisation logic isn't quite right, following the changes to add polyphony. Specifically it only outputs in the second block if the first isn't connected. I think the fix is to replace:
with
In this scenario mono top section will only be present in the first channel of a poly bottom section, which I think is probably the most sensible behaviour. However frustratingly, I'm actually away on holiday for 2 weeks with no access to the developer machine so will be a little difficult to test/validate. @AndrewBelt may be able to help, and I may be able to get access, but worst case it might be a couple of weeks before it gets fixed. |
Thank you fro the reply! |
Fixed in a0acea0 |
Hello,
First of all thank you for the last update! I think that there might be a misbehaving in this module. When you brake the normalisation the second out doesn't work. You can see the led displaying the voltage but it doesn't t output anything.
Thank in advance
The text was updated successfully, but these errors were encountered: