New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chaining Muxlicers doesn't work smoothly #32
Comments
Thanks for the report, will take a look. |
Confirmed the issue, and have a partial fix. It doesn't yet fix problem when externally clocked though, so I will keep working on it.
|
…ooltips/bypasses. Fixes VCVRack#32. Couple of things going on - one is that the 1ms grace period on reset doesn't really work in this context, and breaks EOC chaining which is a common use case. Two, if the clock is already high when a reset was requested, then the boolean trigger detector doesn't detect a rising edge.
Pushed some further changes to address this. One thing that might remain, but is more of a design thing - the switch always has output something on COMI/O, so after the sequence resets on one of the Muxlicers it will output the signal of the first step (even though it's not running). If you want to chain COMIO outputs, rather than summing you can redirect them into a third switch (which can be another muxlicer!) which selects which COMIO to use, rather than summing as in your example: |
* Noise Plethora * Initial release * Chopping Kinky * Upgraded to use improved DC blocker * Spring Reverb * Added bypass * Kickall * Allow trigger input and button to work independently * EvenVCO * Fix to remove pop when number of polyphony engines changes (Fixes #33 ) * Muxlicer * Chaining using reset now works correctly (Fixes #32 )
I just checked the new version, unfortunately it's not completely fixed. The extra low pitch is gone, the hickup between Mux 2 and Mux 1 is gone, but the hickup between Mux 1 and Mux 2 is still there. Note that I started the patch by starting Mux 1 in one-shot mode. The purple gates in the scopes are the combined all-gates outputs, the red and blue trigger are the EOC signals. |
Not sure I understand. They work chained, EOC can be used to switch between gate outs. I'm starting with one shot. selection |
Sorry for the delay and the confusion. Much time has passed and I completely lost track of this. I just tried it again and got slightly different results than in my 2nd screenshot. Then I realized this was only because of the two internal clocks being out of sync. Works fine when I restart VCV or use an external clock. So I can confirm that this is fixed indeed. |
I tried chaining two Muxlicers via EOC -> One-Shot-In connections. Sounds like there's a timing hickup between the two (either way) and also an additional low pitch when going from 1 to 2. When I check the EOC trigger in a scope, it seems to come exactly at the same point as gate 8. Shouldn't it come after gate 8, maybe at the falling edge? Attached screenshot, can't attach saved selection.
The text was updated successfully, but these errors were encountered: