Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pop when adding polyphony channel on EvenVCO #33

Closed
hemmer opened this issue Feb 3, 2022 · 1 comment
Closed

Pop when adding polyphony channel on EvenVCO #33

hemmer opened this issue Feb 3, 2022 · 1 comment
Assignees
@hemmer

Comments

@hemmer
Copy link
Collaborator

hemmer commented Feb 3, 2022

Screen.Recording.2022-02-03.at.22.12.26.mov

Problem
EvenVCO can produce a pop when adding additional polyphony channels. It seems to be because previously unused/uncalculated values of phase / oldPhase / deltaPhase throw off the minBlep calculation.

Solution
The solution is to process the (currently serial) code that does the minBleps for a number of channels that is aligned with the 'simd size', i.e. rounded up to the nearest 4.
hemmer added a commit to hemmer/Befaco that referenced this issue Feb 3, 2022
@hemmer
Fix popping on increase of polyphony channels (EvenVCO)
76822a2 
Fixes VCVRack#33
@hemmer hemmer self-assigned this Feb 3, 2022
@hemmer
Copy link
Collaborator Author

hemmer commented Feb 3, 2022

Fix on PR #31

hemmer added a commit that referenced this issue Mar 8, 2022
@hemmer
Noise Plethora (v2.1.0) (#31)
0cff3b0 
* Noise Plethora
  * Initial release
* Chopping Kinky
  * Upgraded to use improved DC blocker
* Spring Reverb
  * Added bypass
* Kickall
  * Allow trigger input and button to work independently
* EvenVCO
  * Fix to remove pop when number of polyphony engines changes (Fixes #33 )
* Muxlicer
  * Chaining using reset now works correctly (Fixes #32 )
@hemmer hemmer closed this as completed Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hemmer hemmer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hemmer