-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create AS-Drums-n-Filters #315
Conversation
Some nitpicks
|
|
|
Like this is ok? got confused with the "pack" and "manufacturer name" comments:
|
Name refers to the plugin name and was fine originally except without "Pack", it's just unusual to suffix it with "Pack" or "Plugin", since well, that's what it is. The other fixes require a recompile. |
Just noticed, it's done the same way on vcv plugins:
I guess I'm not getting anywhere by myself. |
I think you're confusing plugin slugs with manufacturers. Slugs are always unique IDs that are usually never seen by humans and must never be changed. Manufacturer names are human-readable and help categorize in the Add Module window. The plugin's "name" in the manifests sets the first column of https://vcvrack.com/plugins.html. Ideally, the second column, the "author" should equal the "manufacturer". I need to get Autodafe to set all of his manufacturer strings to "Autodafe". Blamsoft and VCV are the recommended way. |
I also just noticed that you need a .json extension in this file. I'll fix your manifest, but you need to fix your plugin build. Email me a version 0.5.2 when you're ready. |
Indeed I'm mixing things. I think I get it now, let's see (example for v0.5):
then on the cpp file:
and:
This way every module I make (free or paid) will be listed under "AS" in the Add Module window, and that's the expected behavior, right? |
No, you need to use this https://github.com/VCVRack/Template/blob/master/src/Template.cpp#L8-L10 Yes to your |
Neat!, doing the plugin build now. |
No description provided.