Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create AS-Drums-n-Filters #315

Merged
merged 1 commit into from
Mar 11, 2018
Merged

Create AS-Drums-n-Filters #315

merged 1 commit into from
Mar 11, 2018

Conversation

AScustomWorks
Copy link
Contributor

No description provided.

@AndrewBelt AndrewBelt merged commit 8f55ebd into VCVRack:master Mar 11, 2018
@AndrewBelt
Copy link
Member

AndrewBelt commented Mar 11, 2018

Some nitpicks

  • I feel it that "Pack" should be removed from the human-readable name.
  • I don't see a manual on the page that the manual property points to, so it should be removed until one is added.

@AndrewBelt
Copy link
Member

  • The manufacturer name should be "AS", not "AS-Drums-n-Filters"

@AndrewBelt
Copy link
Member

  • The [Filters] prefix looks weird. Maybe remove it?

@AScustomWorks
Copy link
Contributor Author

Like this is ok? got confused with the "pack" and "manufacturer name" comments:

{
  "slug": "AS-Drums-n-Filters",
  "name": "AS",
  "author": "Alfredo Santamaria",
  "license": "proprietary",
  "version": "0.5.0",
  "homepage": "http://www.hakken.com.mx/ascustomworks/",
  "manual": "",
  "productId": "1083015692331"
}

@AndrewBelt
Copy link
Member

AndrewBelt commented Mar 11, 2018

Name refers to the plugin name and was fine originally except without "Pack", it's just unusual to suffix it with "Pack" or "Plugin", since well, that's what it is.
Manufacterer is your "brand", which is "AS".
Remove the "manual" property completely. A blank string is invalid

The other fixes require a recompile.

@AScustomWorks
Copy link
Contributor Author

AScustomWorks commented Mar 11, 2018

Oh, ok then:

{
  "slug": "AS-Drums-n-Filters",
  "name": "AS Drums & Filters",
  "author": "Alfredo Santamaria",
  "license": "proprietary",
  "version": "0.5.0",
  "homepage": "http://www.hakken.com.mx/ascustomworks/",
  "productId": "1083015692331"
}

Question: changing the slug here to AS instead of AS-Drums-n-Filters, will conflict with the compiled plugin, right? Made it like that to avoid mixing the module list with free and paid modules, for example:
modules

Also this entries look similar:

  "slug": "Blamsoft-XFXDistortionPack",
  "name": "XFX Distortion Pack",

    "slug": "Blamsoft-XFXF35",
  "name": "XFX F-35",

Sorry, I'm still confused with your instructions vs what can be seen on the other slugs, but I'll do as you instruct, as soon as I understand all right ;)

@AScustomWorks
Copy link
Contributor Author

Just noticed, it's done the same way on vcv plugins:

  "slug": "VCV-Console",
  "name": "Console",

  "slug": "VCV-PulseMatrix",
  "name": "Pulse Matrix",

I guess I'm not getting anywhere by myself.

@AndrewBelt
Copy link
Member

AndrewBelt commented Mar 11, 2018

I think you're confusing plugin slugs with manufacturers. Slugs are always unique IDs that are usually never seen by humans and must never be changed. Manufacturer names are human-readable and help categorize in the Add Module window. The plugin's "name" in the manifests sets the first column of https://vcvrack.com/plugins.html. Ideally, the second column, the "author" should equal the "manufacturer".

I need to get Autodafe to set all of his manufacturer strings to "Autodafe". Blamsoft and VCV are the recommended way.

@AndrewBelt
Copy link
Member

AndrewBelt commented Mar 11, 2018

I also just noticed that you need a .json extension in this file.

I'll fix your manifest, but you need to fix your plugin build. Email me a version 0.5.2 when you're ready.

@AScustomWorks
Copy link
Contributor Author

AScustomWorks commented Mar 11, 2018

Indeed I'm mixing things. I think I get it now, let's see (example for v0.5):
On the makefile:

SLUG = AS-Drums-n-Filters (this keeps the plugin on a unique folder)

then on the cpp file:

p->slug = "AS"; (it should be "AS" always in my case)

and:

p->addModel(createModel<Drums8x8KicksWidget>("AS", ...etc

This way every module I make (free or paid) will be listed under "AS" in the Add Module window, and that's the expected behavior, right?

@AndrewBelt
Copy link
Member

No, you need to use this https://github.com/VCVRack/Template/blob/master/src/Template.cpp#L8-L10

Yes to your addModel call.

@AScustomWorks
Copy link
Contributor Author

Neat!, doing the plugin build now.

@AScustomWorks AScustomWorks deleted the patch-6 branch March 13, 2018 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants