-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Line plot master ticket: markers and connection lines #602
Comments
VEuPathDB/web-eda#1411 was created because markers were appearing at X-axis values that were not in the subset, which made it look like the Y-axis proportion for these X-axis values was equal to 0 instead of not having any rows of data for these X-axis values VEuPathDB/web-eda#1519 was created because a connecting line should be drawn through the markers. Lines should be drawn even in instances where an X-axis value has data in the full dataset but does NOT contain a marker because it does not have data in the subset (In that case, the line should be drawn between the 2 markers immediately adjacent to the X-axis value that does not have data in the subset). Unrelated to these tickets, VEuPathDB/web-eda#1082 was created because markers for X-axis values that were IN the subset but did not have any Y-axis values that were included in the proportion calculation (ie, had an undefined proportion, 0/0) looked like they had a proportion equal to 0. we wanted some sort of marker at these X-axis values to indicate that the subset does contain data for that X-axis value and the proportion configurations do not remove this data from the subset. Connecting lines should NEVER go through hollow markers. If 2 filled markers are separated by a hollow marker, there will be a break in the line |
This means the same thing as:
For example, Since the numerator cannot be a superset of the denominator, There can be some values of These points where The only time hollow unconnected points are ever used is where |
Hi @danicahelb - thank you so much for consolidating everything here. I think there could be some more discussion either in EDA UX or data viz about breaking the lines. We may want different behaviour depending on direct vs. indirect filtering (e.g. the new filter-aware behaviours we've talked about)
Not 100% sure of the reasoning myself, and only briefly discussed with Danielle, so I suggest it goes to committee! |
This is the master ticket for related line plot tickets VEuPathDB/web-eda#1411, VEuPathDB/web-eda#1519 and VEuPathDB/web-eda#1082, as fixes to one issue are having downstream affects and creating other issues.
I will use this hypothetical example:
X- axis variable
Timepoint
Timepoint
= 2)Timepoint
= 2 in the full dataset, andTimepoint
= 3 has been removed from the subset either by directly filtering onTimepoint
or indirectly by filtering on other variables in the dataset)Y-axis variable
Malaria
Timepoint
=4, the study protocol indicated that no participants were tested for malaria (so all participants haveMalaria
= Not tested atTimepoint
= 4)This is what we want:
Timepoint
= 2, 3. Lines should connectTimepoint
1 toTimepoint
4.Timepoint
= 2, 3 and Filled markers atTimepoints
1, 4, 5, 6, and 7 whenMalaria
proportion = Yes/(Yes+No+Not tested). Lines should connectTimepoint
1 toTimepoint
4 toTimepoint
5 toTimepoint
6 toTimepoint
7Timepoint
= 2, 3 and Hollow markers at Timepoint = 4 and filled markers atTimepoint
= 1, 5, 6, and 7 whenMalaria
proportion = Yes/(Yes+No). There should be a break in the line whenever there is a hollow marker. So the filled marker atTimepoint
= 1 would NOT be connected toTimepoint
4, andTimepoint
4 would not be connected toTimepoint
5. But a line would connectTimepoint
5 toTimepoint
6 toTimepoint
7The text was updated successfully, but these errors were encountered: