Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Line plot bug: no line is being drawn between discrete points #1519

Closed
danicahelb opened this issue Dec 7, 2022 · 7 comments · Fixed by #1531 or VEuPathDB/web-monorepo#118
Closed
Assignees
Labels
bug Something isn't working

Comments

@danicahelb
Copy link

danicahelb commented Dec 7, 2022

Requires UX discussion before implementation:

In SCORE S. mansoni study, I filtered the data so that Village study arm = Arm 6: Gaining-shsh

This results in having data at just the following timepoints:

image

When I make a line plot of this subset, plotting S. mansoni against study timepoint I get the following plot:

image

My issue with the line plot is that is is a series of discrete points instead of a line plot. It is appropriate for a line to be drawn connecting the markers at Year 1, Year 3, and Year 5 to see how prevalence of schisto goes down over the course of the study

@danicahelb danicahelb added the UX topic indicates the issue is paused for discussion in EDA UX meeting label Dec 7, 2022
@dmfalke dmfalke transferred this issue from VEuPathDB/EdaNewIssues Dec 8, 2022
@moontrip moontrip self-assigned this Dec 11, 2022
@danicahelb danicahelb added bug Something isn't working and removed UX topic indicates the issue is paused for discussion in EDA UX meeting labels Dec 12, 2022
@danicahelb
Copy link
Author

Discussed in 12/12 EDA UX meeting. This is a BUG related to #1411

Once the related bug is fixed, we would expect that a line gets drawn between the remaining data points. If that does not happen, then @moontrip please fix the bug in this ticket as well. Thanks!

@danicahelb
Copy link
Author

@nkittur-uga now that the bug has been fixed, can you see if there is the expected gap in the line now?

@nkittur-uga
Copy link
Member

I'm afraid I still don't see the line connecting the points. (Same example as above)
Screenshot 2023-01-19 at 1 28 20 PM

@danicahelb danicahelb reopened this Jan 19, 2023
@danicahelb danicahelb changed the title Line plot: no line drawn between discrete points separated by no data Line plot bug: no line is being drawn between discrete points Mar 1, 2023
@danicahelb
Copy link
Author

Hey @moontrip I think this ticket does NOT depend on implementation of #1082

@moontrip
Copy link
Contributor

moontrip commented Mar 1, 2023

@danicahelb Thank you for your confirmation 👍 Then it is almost ready for merging actually 😄 I will do that

@danicahelb
Copy link
Author

Looks great, thanks @moontrip!

Image

@moontrip
Copy link
Contributor

moontrip commented Mar 6, 2023

@danicahelb Thank you for your reviews and tests. Glad it worked out 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
3 participants