-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add a lineplot prop to enable connecting points #431
Conversation
Would another way to address this be to remove the "missing data" points from the data series? Or, alternatively, is there ever a reason to not have these lines? If not, then should we always proceed to connect points, which would obviate the need for this prop? |
I see in your description of VEuPathDB/web-eda#1531 that removing the missing data is too complex. My second question stands: can we just assume we always want points connected? |
@dmfalke Although I said it would be too complex, I may need to consider it depending on another ticket, VEuPathDB/web-eda#1082. I didn't look into the requirements carefully yet though. For your second question, I think yes? 😄 That's the reason why I did set it to be true at this corresponding web-eda PR: VEuPathDB/web-eda#1531. The plotly prop should be set at data (processedData) level. |
Can't tell whether @dave's question ( |
@dmfalke @moontrip @chowington regarding
No. we have agreed with @d-callan that if the data series contains 0/0 there will be a break in the line. Perhaps we should wait until mockups for VEuPathDB/web-eda#1082 are finalized and the new UI is implemented? |
This is to define a type for a new lineplot prop, which will be used for VEuPathDB/web-eda#1519.