Clean up selectedValues type

VEuPathDB · Jun 29, 2023 · cbdd30c · cbdd30c · bobular · Jun 29, 2023
1 parent 69d5cf9
commit cbdd30c
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 7 deletions.
diff --git a/...ages/libs/eda/src/lib/map/analysis/MarkerConfiguration/BarPlotMarkerConfigurationMenu.tsx b/...ages/libs/eda/src/lib/map/analysis/MarkerConfiguration/BarPlotMarkerConfigurationMenu.tsx
@@ -27,7 +27,6 @@ interface MarkerConfiguration<T extends string> {
 export interface BarPlotMarkerConfiguration
   extends MarkerConfiguration<'barplot'>,
     SharedMarkerConfigurations {
-  selectedValues: OverlayConfig['overlayValues'] | undefined;
   selectedPlotMode: 'count' | 'proportion';
   dependentAxisLogScale: boolean;
 }

diff --git a/packages/libs/eda/src/lib/map/analysis/MarkerConfiguration/PieMarkerConfigurationMenu.tsx b/packages/libs/eda/src/lib/map/analysis/MarkerConfiguration/PieMarkerConfigurationMenu.tsx
@@ -27,12 +27,11 @@ export interface SharedMarkerConfigurations {
   selectedVariable: VariableDescriptor;
   binningMethod: 'equalInterval' | 'quantile' | 'standardDeviation' | undefined;
   selectedCountsOption: 'filtered' | 'visible' | undefined;
+  selectedValues: string[] | undefined;
 }
 export interface PieMarkerConfiguration
   extends MarkerConfiguration<'pie'>,
-    SharedMarkerConfigurations {
-  selectedValues: string[] | undefined;
-}
+    SharedMarkerConfigurations {}
 
 interface Props
   extends Omit<

diff --git a/packages/libs/eda/src/lib/map/analysis/appState.ts b/packages/libs/eda/src/lib/map/analysis/appState.ts
@@ -4,9 +4,7 @@ import * as t from 'io-ts';
 import { isEqual } from 'lodash';
 import { useCallback, useEffect } from 'react';
 import {
-  AllValuesDefinition,
   AnalysisState,
-  BinDefinitions,
   useGetDefaultVariableDescriptor,
   useStudyMetadata,
 } from '../../core';
@@ -29,7 +27,7 @@ export const MarkerConfiguration = t.intersection([
   t.union([
     t.type({
       type: t.literal('barplot'),
-      selectedValues: t.union([BinDefinitions, t.array(t.string), t.undefined]), // user-specified selection
+      selectedValues: t.union([t.array(t.string), t.undefined]), // user-specified selection
       selectedPlotMode: t.union([t.literal('count'), t.literal('proportion')]),
       binningMethod: t.union([
         t.literal('equalInterval'),