Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add groupBySelected filter to orthologs record table #1017

Merged
merged 4 commits into from
Apr 26, 2024

Conversation

jernestmyers
Copy link
Contributor

@jernestmyers jernestmyers commented Apr 17, 2024

@dmfalke
Copy link
Member

dmfalke commented Apr 17, 2024

I was thinking that this should be a part of Mesa, and that we should use the "switch" component, like we have in eda subsetting. I also think it should appear next to the selection info.

The state would be maintained by the consumer of Mesa, while the ordering would have to be done by the consumer. It would appear only if selection is enabled. If need be, we can add another prop to hide the feature.

Thoughts?

@jernestmyers jernestmyers marked this pull request as ready for review April 26, 2024 13:32
Copy link
Member

@dmfalke dmfalke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks nice!

@jernestmyers jernestmyers force-pushed the add-groupBySelected-filter-to-orthologs branch from f9582b9 to a4f4207 Compare April 26, 2024 15:06
@jernestmyers jernestmyers merged commit fa591ee into main Apr 26, 2024
1 check passed
@jernestmyers jernestmyers deleted the add-groupBySelected-filter-to-orthologs branch April 26, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants