Add plot controls to volcano plots #404
Conversation
There was a problem hiding this comment.
Looks great! Works perfectly! Can we put the marker opacity slider under Plot Controls please?
And i agree with all the notes you left. We don't need the auto-zoom, full, and custom because we don't have a difference between auto-zoom and full, since there are no display ranges here!
| @@ -166,6 +166,24 @@ const modalPlotContainerStyles = { | |||
| margin: 'auto', | |||
| }; | |||
|
|
|||
| // implement gradient color for slider opacity | |||
| export const colorSpecProps: SliderWidgetProps['colorSpec'] = { | |||
There was a problem hiding this comment.
since we're going to use this elsewhere, shall we give it a more descriptive name? Maybe sliderOpacityColorSpecProps? Or something with "gradient color" in it?
There was a problem hiding this comment.
I wonder do we have anywhere more general for this to live?
There was a problem hiding this comment.
I remember thinking the same thing, so I'll see what I can come up with!
...libs/eda/src/lib/core/components/visualizations/implementations/VolcanoPlotVisualization.tsx
Show resolved
Hide resolved
...libs/eda/src/lib/core/components/visualizations/implementations/VolcanoPlotVisualization.tsx
Outdated
Show resolved
Hide resolved
...libs/eda/src/lib/core/components/visualizations/implementations/VolcanoPlotVisualization.tsx
Outdated
Show resolved
Hide resolved
Do we have any concerns that it lines up beneath the x-axis controls? |
|
sorry my comment was too vague - i mean can the opacity live in its own section called Plot Controls? Like we do on the scatterplot where it says Plot Mode (marker opacity shouldn't really be in. the Plot Mode section, instead that section should be called Plot Controls or something... anyways... lol). My hope is to prevent the friendly opacity slider from floating around without a section header to guide it 😄 
|
|
Updated screenshot:
|
Resolves items 5 and 6 from #358
NOTE: this work is branched off of #392(merged)Notes:
Math.floor()on the min values andMath.ceil()on the max values.X-axis controlswith `X-axis range beneath it and likewise for the y-axis. It felt weird to have the Header/Subheader relationship when the only controls are for the ranges.Happy to make any changes to the decisions/assumptions I made.