Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated volcano colors for accessibility and function #464

Merged
merged 2 commits into from
Sep 8, 2023

Conversation

asizemore
Copy link
Member

Resolves #67

After a long discussion in the data viz meeting yesterday (see notes here), finally we came to an agreement.

I did double check contrast ratios for tooltips as well! Nothing had to change there :)

Copy link
Member

@dmfalke dmfalke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just saw this sitting in the queue, and decided to review it. Looks good!

@asizemore asizemore merged commit 349fa3e into main Sep 8, 2023
1 check passed
@asizemore asizemore deleted the fix-67-volcano-colors branch September 8, 2023 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Volcano: finalize colors
2 participants