Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updated volcano colors for accessibility and function #464

Merged
merged 2 commits into from
Sep 8, 2023
Merged

updated volcano colors for accessibility and function #464

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
df76da6
updated volcano colors for accessibility and function
asizemore Aug 31, 2023
947396c
Merge branch 'main' into fix-67-volcano-colors
asizemore Sep 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/libs/components/src/stories/plots/VolcanoPlot.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,7 +191,7 @@ Simple.args = {
export const ManyPoints = Template.bind({});
ManyPoints.args = {
data: dataSetVolcanoManyPoints,
markerBodyOpacity: 0.5,
markerBodyOpacity: 0.8,
log2FoldChangeThreshold: 3,
significanceThreshold: 0.01,
independentAxisRange: { min: -9, max: 9 },
Expand Down
6 changes: 3 additions & 3 deletions packages/libs/components/src/types/plots/addOns.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -334,9 +334,9 @@ export type SignificanceColors = {
low: string;
};
export const significanceColors: SignificanceColors = {
inconclusive: '#B5B8B4',
high: '#AC3B4E',
low: '#0E8FAB',
inconclusive: '#8f8f8f',
high: '#a8484b',
low: '#007F5C',
};

/** truncated axis flags */
Expand Down
2 changes: 1 addition & 1 deletion ...s/eda/src/lib/core/components/visualizations/implementations/VolcanoPlotVisualization.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ import { fixVarIdLabel } from '../../../utils/visualization';

const DEFAULT_SIG_THRESHOLD = 0.05;
const DEFAULT_FC_THRESHOLD = 2;
const DEFAULT_MARKER_OPACITY = 0.7;
const DEFAULT_MARKER_OPACITY = 0.8;
/**
* The padding ensures we don't clip off part of the glyphs that represent the most extreme points.
* We could have also used d3.scale.nice but then we dont have precise control of where the extremes
Expand Down
Loading