Constant in pkg files cause issues in AnalyzeObjects due to _identifiers vs _identifier

[Tcenova]

/python3.11/site-packages/pyVHDLModel/init.py", line 705, in _ImportObjects
package._namespace._elements[declaredItem._identifier] = declaredItem
^^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: 'Constant' object has no attribute '_identifier'. Did you mean: '_identifiers'?

I assume this may also cause issues with other elements which use _identifiers. I am not sure how to solve this correctly. I have a local workaround to access the zeroth element of _identifiers for now (when declaredItem has the attr _identifiers).

[Paebbels]

There was once a change in the model, because a constant declaration can have multiple identifiers.

constant a, b : integer := 5;

I thought I found all places referring to _identifier when it was changed to _identifiers. A quick workaround would be defaulting to the first identifier as in many VHDL sources that will be the case.

But at the end the problem needs a solution.

[Tcenova]

See PR for potential solution. I think it may be the correct route, since it would desirable for a and b to point to the constant type. I used the following as the as the basis for the solution, but generalized it by looking for an attr of the object instead of specific object types.

pyVHDLModel/pyVHDLModel/Regions.py

Lines 141 to 144 in 8086c37

	elif isinstance(item, Constant):
	for normalizedIdentifier in item._normalizedIdentifiers:
	self._constants[normalizedIdentifier] = item
	self._namespace._elements[normalizedIdentifier] = item

Do you think this is a good solution?

[Paebbels]

#82 looks good. I proposed a minor change to it.