-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix package namespace bugs #82
Conversation
…entifier. This caused issues where elements would not be found if identifier and normalizedIdentifier did not match.
…onstants), then this code would fail. Adding a check to see if the _normalizedIdentifiers attr exists, and if so add a entry for each identifier
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use the proposed isinstance
to check for the mixin been used to offer either a single name or multiple names.
Co-authored-by: Patrick Lehmann <Paebbels@gmail.com>
@Tcenova did the merged version run in your report by a GitHub pipeline? Since GitHub got stupid about pipelines, I can't see any pipeline running for contributions to check for correctness. I need to merge it and see it fail in my account. Previously, it started a pipeline in the fork and displayed the results in my pipeline overview too. |
I pushed a fixed version to |
I am not sure. I have never used GitHub pipelines before. Where would I check? |
I checked here: https://github.com/Tcenova/pyVHDLModel/actions Hmmm there is no pipeline. WTF has GitHub changed ... This explains why I see no results, but why does it not launch in your account/fork...? |
Ah. Because it defaults to not running in forks. I get the message:
I get an option to enable them on the fork. I will do so, so hopefully it will run if I end up submitting other PRs. I do see a code check on this PR under the "Checks" tab which links to: https://app.codacy.com/gh/VHDL/pyVHDLModel/pull-requests/82/issues |
Please activate and lets see if it works next time. The latter was fixed by ma new push. the f-string can be converted to a normal string. |
Bug Fixes