-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow trailing comma for function use and parameter lists #664
base: master
Are you sure you want to change the base?
Allow trailing comma for function use and parameter lists #664
Conversation
1be3414
to
6c012c8
Compare
Hi! I would suggest adding the tests.
Basically, this feature should work when it works in PHP and fail to compile when it's not a valid syntax for PHP. You may look at the PHP pull request for an inspiration. It probably includes some tests. See the docs for more info about contributing (how to run tests, etc.) Or you can ask the questions here. |
6c012c8
to
1f5cfa1
Compare
Please check |
a7fe9c3
to
f452192
Compare
f5937ec
to
8f78498
Compare
8f78498
to
19abded
Compare
Support PHP8 feature.
Main issue: #290
Previous attempt: #308
I didn't rebase because of merge conflict.