Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Load cpp dest dir in a separate thread #87

Merged
merged 2 commits into from
Jan 25, 2021
Merged

Load cpp dest dir in a separate thread #87

merged 2 commits into from
Jan 25, 2021

Conversation

AlexK0
Copy link
Contributor

@AlexK0 AlexK0 commented Dec 28, 2020 •
edited
Loading

  1. Move cpp destination directory initialization logic into separate pipe.
  2. Move CollectForkableTypes into separate file and pipe.

@AlexK0 AlexK0 force-pushed the alexko/profile-sync-cpp-dir branch 8 times, most recently from 3bb6b86 to 3457080 Compare December 28, 2020 15:33
unserialize
unserialize reviewed Dec 28, 2020
View reviewed changes
compiler/pipes/collect-forkable-types.h Outdated Show resolved Hide resolved
compiler/pipes/collect-forkable-types.h Outdated Show resolved Hide resolved
compiler/pipes/init-cpp-dest-dir.cpp Outdated Show resolved Hide resolved
compiler/pipes/init-cpp-dest-dir.h Outdated Show resolved Hide resolved
compiler/compiler.cpp Outdated Show resolved Hide resolved
@unserialize unserialize added this to the next milestone Jan 13, 2021
@AlexK0 AlexK0 force-pushed the alexko/profile-sync-cpp-dir branch 4 times, most recently from 4cce8d6 to 805dffb Compare January 15, 2021 09:56
unserialize
unserialize reviewed Jan 15, 2021
View reviewed changes
compiler/compiler.cpp Outdated Show resolved Hide resolved
@AlexK0 AlexK0 force-pushed the alexko/profile-sync-cpp-dir branch from 805dffb to 7cf678e Compare January 15, 2021 12:45
@unserialize unserialize changed the title Remove extra logic from code gen. Load pp dest dir in a separate thread Jan 22, 2021
@unserialize unserialize changed the title Load pp dest dir in a separate thread Load cpp dest dir in a separate thread Jan 22, 2021
@unserialize unserialize added the optimization Memory comsumption / CPU speedup label Jan 22, 2021
@AlexK0 AlexK0 merged commit 1efcdf0 into master Jan 25, 2021
@AlexK0 AlexK0 deleted the alexko/profile-sync-cpp-dir branch January 25, 2021 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@unserialize unserialize unserialize approved these changes

@DrDet DrDet DrDet approved these changes

Assignees
No one assigned
Labels
optimization Memory comsumption / CPU speedup
Projects
None yet
Milestone
28.01.2021
Development

Successfully merging this pull request may close these issues.
3 participants
@AlexK0 @DrDet @unserialize