Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add curlopt_accept_encoding #951

Merged
merged 1 commit into from
Dec 6, 2023
Merged

add curlopt_accept_encoding #951

merged 1 commit into from
Dec 6, 2023

Conversation

astrophysik
Copy link
Contributor

No description provided.

@astrophysik astrophysik self-assigned this Dec 6, 2023
@astrophysik astrophysik added the small fix When it's not an huge enhancement label Dec 6, 2023
@astrophysik astrophysik added this to the next milestone Dec 6, 2023
DrDet
DrDet reviewed Dec 6, 2023
View reviewed changes
Copy link
Contributor

@DrDet DrDet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't find option CURLOPT_ACCEPT_ENCODING in php. It seems like it has another name

@Danil42Russia
Copy link
Contributor

I can't find option CURLOPT_ACCEPT_ENCODING in php. It seems like it has another name

This is a documentation problem (it is not there), in the php sources this constant is present

https://github.com/php/php-src/blob/6f569b42fa05462c835f7389ba3af1653e5a9bef/ext/curl/curl_arginfo.h#L680

@astrophysik astrophysik merged commit f035b13 into master Dec 6, 2023
5 checks passed
@astrophysik astrophysik deleted the vsadokhov/curl-accept-encoding branch December 6, 2023 16:46
@Danil42Russia Danil42Russia added enhancement New feature or request runtime Feature related to runtime and removed small fix When it's not an huge enhancement labels Dec 10, 2023
DedAzaMarks pushed a commit to DedAzaMarks/kphp that referenced this pull request Dec 13, 2023
@astrophysik @DedAzaMarks
add curlopt_accept_encoding (VKCOM#951)
a8e7df5
mt-omarov pushed a commit to mt-omarov/kphp that referenced this pull request Feb 26, 2024
@astrophysik @mt-omarov
add curlopt_accept_encoding (VKCOM#951)
4130ac7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DrDet DrDet DrDet left review comments

@Danil42Russia Danil42Russia Danil42Russia approved these changes

Assignees

@astrophysik astrophysik

Labels
enhancement New feature or request runtime Feature related to runtime
Projects
None yet
Milestone
10.12.2023
Development

Successfully merging this pull request may close these issues.
3 participants
@astrophysik @Danil42Russia @DrDet