Sample and marshal recent and historic buckets together #1188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
razmser
force-pushed
the
razmser/single_marshalling
branch
3 times, most recently
from
a993aec
to
1bac5f4
Compare
razmser
force-pushed
the
razmser/single_marshalling
branch
3 times, most recently
from
6114b0f
to
affc529
Compare
Semantic of builtin __agg_* metrics changes here historic tag now always means that metric was calculated for both recent and historic buckets recent tag on other hand means that metric was only calculated for recent bucket We already had this semantic for __agg_insert_size_real now it's consistent for all metrics.
To preserve current __agg_insert_size behaviour
razmser
force-pushed
the
razmser/single_marshalling
branch
from
affc529
to
97155ff
Compare
nevgeny
approved these changes
May 27, 2024
alpinskiy
approved these changes
May 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.