Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hiroshiba
commented
Mar 4, 2024
src/sing/domain.ts
Outdated
Comment on lines
290
to
296
| export function isValidGuideVolumeScale(guideVolumeScale: number) { | ||
| return ( | ||
| Number.isInteger(guideVolumeScale) && | ||
| guideVolumeScale <= 20 && | ||
| guideVolumeScale >= -20 | ||
| ); | ||
| } |
There was a problem hiding this comment.
結構大きめ。いろんなキャラ試した感じ15あれは十分そうだけど、まあ大きめにしてみています。
Hiroshiba
commented
Mar 4, 2024
src/store/singing.ts
Outdated
| frameAudioQuery: FrameAudioQuery | ||
| ) => { | ||
| frameAudioQuery.volume = frameAudioQuery.volume.map((value) => { | ||
| return value * Math.pow(10, guideVolumeScale / 20); |
There was a problem hiding this comment.
frameAudioQuery.volumeの単位は振幅です。
guideVolumeScaleの単位はdBということにしているので*= 10^(n/20)で良いはず。
|
こちらの機能がないとリリースできないキャラがいるので、ちょっと申し訳ないのですがレビューなしでもマージさせていただこうと思います！ |
Hiroshiba
force-pushed
the
ボリューム補正機能
branch
2 times, most recently
from
1057c1e
to
cad7ef6
Compare
Hiroshiba
commented
Mar 7, 2024
Comment on lines
-422
to
+458
| width: 50px; | ||
| width: 55px; |
There was a problem hiding this comment.
5文字になった方に合わせたのでちょっと横を長く
|
ちょっともしかしたら実装ミスあるかもなのですが、緊急よりということでマージさせていただきます 🙇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
ガイドで生成された歌い方の音量を、ハミング合成する前にデシベル単位で大きくしたり小さくしたりできます。
一部のキャラクターで音量が小さいことが問題だったので、大きくできるようにしたという文脈です。
の解決プルリクエストです。
パラメーターの名称はこちらに合わせました。
関連 Issue
resolve #1870
その他