Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

リリース時にバージョン情報が自動的に入るようにする #660

Conversation

Hiroshiba
Copy link
Member

@Hiroshiba Hiroshiba commented Jan 23, 2022

内容

詳細はissueに記載しています

npm versionはalpha等が付いていても大丈夫っぽいので、普通にpackage.jsonのversionを書き換えてみました。

関連 Issue

close #659

スクリーンショット・動画など

その他

エンジン側のコードに寄せてみました

2022/01/23 21:59 release作ってみました
https://github.com/VOICEVOX/voicevox/releases/tag/0.10.check.0

2022/01/23 22:07 0.10.preview.0のタグ名だとダメだったので再度挑戦しました
https://github.com/VOICEVOX/voicevox/releases/tag/0.10.0-preview.0

@Hiroshiba
Copy link
Member Author

ちゃんとビルドできてそうでした!レビューよろしくお願いします・・・!

Copy link
Member

@PickledChair PickledChair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@aoirint aoirint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@aoirint aoirint merged commit 39b6d37 into main Jan 24, 2022
@Hiroshiba Hiroshiba deleted the リリース時にバージョン情報が自動的に入るようにする branch January 28, 2022 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

リリース時にバージョン情報が自動的に入るようにする
3 participants