Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VERSION.txtを消去し、releaseビルド時に自動的にバージョン名が入るようにした #288

Merged
merged 3 commits into from
Jan 15, 2022

Conversation

Hiroshiba
Copy link
Member

内容

  • VERSION.txt削除
  • voicevox_engine/__init__.pyにバージョン情報を記載
  • release時に自動的にバージョン名が入るように
  • なにもないときはlatestに

関連 Issue

close #274

その他

npmのpackage.jsonのversionのような高尚な仕組みが見当たらなかったので、ソースコードに直書きし、sedで置き換える設計にしました。

@coveralls
Copy link

coveralls commented Jan 15, 2022

Pull Request Test Coverage Report for Build 1701825846

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 86.432%

Totals Coverage Status
Change from base Build 1697072090: 0.02%
Covered Lines: 688
Relevant Lines: 796

💛 - Coveralls

@github-actions
Copy link

github-actions bot commented Jan 15, 2022

Coverage Result

Resultを開く
Name Stmts Miss Cover
voicevox_engine/init.py 1 0 coverage-100%
voicevox_engine/acoustic_feature_extractor.py 85 0 coverage-100%
voicevox_engine/dev/synthesis_engine/init.py 2 0 coverage-100%
voicevox_engine/dev/synthesis_engine/mock.py 29 0 coverage-100%
voicevox_engine/full_context_label.py 167 5 coverage-97%
voicevox_engine/kana_parser.py 89 1 coverage-99%
voicevox_engine/model.py 71 7 coverage-90%
voicevox_engine/mora_list.py 4 0 coverage-100%
voicevox_engine/preset/Preset.py 12 0 coverage-100%
voicevox_engine/preset/PresetLoader.py 34 1 coverage-97%
voicevox_engine/preset/init.py 3 0 coverage-100%
voicevox_engine/synthesis_engine/init.py 5 0 coverage-100%
voicevox_engine/synthesis_engine/forwarder.py 76 66 coverage-13%
voicevox_engine/synthesis_engine/make_synthesis_engine.py 25 20 coverage-20%
voicevox_engine/synthesis_engine/synthesis_engine.py 107 0 coverage-100%
voicevox_engine/synthesis_engine/synthesis_engine_base.py 49 5 coverage-90%
voicevox_engine/utility/init.py 2 0 coverage-100%
voicevox_engine/utility/connect_base64_waves.py 35 3 coverage-91%
TOTAL 796 108 coverage-86%

@Hiroshiba
Copy link
Member Author

release作成しました。
https://github.com/VOICEVOX/voicevox_engine/releases/tag/check-bcf6c125000a5c87c4a87bbb6d154d6dcc92b0c4

windows-cpuでバージョン名が入っていることを確認しました。

Copy link
Member

@aoirint aoirint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

release.tag_nameをquoteしたい気もしますが、いい方法がわからないです...

Copy link
Member

@PickledChair PickledChair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! マージしますね

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VERSION.txtを自動生成したい
4 participants