Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PyPIにアップロードするためのGitHub actions #658

Closed
wants to merge 0 commits into from

Conversation

tuna2134
Copy link

@tuna2134 tuna2134 commented Oct 26, 2023

内容

maturinのテンプレ使っています。
ただしvoicevoxに合うように調整しています。

関連 Issue

close #653

(例)
ref #0
close #0
-->

その他

とくになし

@qryxip
Copy link
Member

qryxip commented Oct 26, 2023

#660 をマージしました。test_utilはdev-dependenciesへの移動ではなく丸ごとの削除となっています。

@Hiroshiba
Copy link
Member

@qryxip さんがうまくmaturin buildまで進められるワークアラウンド作ってくださったので共有です・・・!

@qryxip
Copy link
Member

qryxip commented Oct 29, 2023

補足しておくとopen_jtalk-sysの問題が発生するのはmacos-12 (=macos-latest)であり、macos-11では発生しません。そのため #664 ではmacos-latestでのmaturin (develop|build)の「テスト」(≠ リリースビルドのデプロイ)でのみ、Maturinの前にcargo buildすることで問題を回避しています。

リリースするwheel/sdistをビルドする際には、runs-onは現状のbuild_and_deploy.ymlの通りにwindows-2019, ubuntu-20.04, macos-11にするのが適切かと思います。Ubuntu 20もmacOS 11もまだ多くの人が使っていると思われるので。

includes='[
{
"os": "windows-2019",
"features": "",
"target": "x86_64-pc-windows-msvc",
"artifact_name": "windows-x64-cpu",
"whl_local_version": "cpu",
"use_cuda": false,
"can_skip_in_simple_test": true
},
{
"os": "windows-2019",
"features": "directml",
"target": "x86_64-pc-windows-msvc",
"artifact_name": "windows-x64-directml",
"whl_local_version": "directml",
"use_cuda": false,
"can_skip_in_simple_test": false
},
{
"os": "windows-2019",
"features": "",
"target": "x86_64-pc-windows-msvc",
"artifact_name": "windows-x64-cuda",
"whl_local_version": "cuda",
"use_cuda": true,
"can_skip_in_simple_test": true
},
{
"os": "windows-2019",
"features": "",
"target": "i686-pc-windows-msvc",
"artifact_name": "windows-x86-cpu",
"whl_local_version": "cpu",
"use_cuda": false,
"can_skip_in_simple_test": true
},
{
"os": "ubuntu-20.04",
"features": "",
"target": "x86_64-unknown-linux-gnu",
"artifact_name": "linux-x64-cpu",
"whl_local_version": "cpu",
"use_cuda": false,
"can_skip_in_simple_test": true
},
{
"os": "ubuntu-20.04",
"features": "",
"target": "x86_64-unknown-linux-gnu",
"artifact_name": "linux-x64-gpu",
"whl_local_version": "cuda",
"use_cuda": true,
"can_skip_in_simple_test": false
},
{
"os": "ubuntu-20.04",
"features": "",
"target": "aarch64-unknown-linux-gnu",
"artifact_name": "linux-arm64-cpu",
"whl_local_version": "cpu",
"use_cuda": false,
"can_skip_in_simple_test": true
},
{
"os": "ubuntu-20.04",
"features": "",
"target": "aarch64-linux-android",
"artifact_name": "android-arm64-cpu",
"use_cuda": false,
"can_skip_in_simple_test": true
},
{
"os": "ubuntu-20.04",
"features": "",
"target": "x86_64-linux-android",
"artifact_name": "android-x86_64-cpu",
"use_cuda": false,
"can_skip_in_simple_test": true
},
{
"os": "macos-11",
"features": "",
"target": "aarch64-apple-darwin",
"artifact_name": "osx-arm64-cpu",
"whl_local_version": "cpu",
"use_cuda": false,
"can_skip_in_simple_test": false
},
{
"os": "macos-11",
"features": "",
"target": "x86_64-apple-darwin",
"artifact_name": "osx-x64-cpu",
"whl_local_version": "cpu",
"use_cuda": false,
"can_skip_in_simple_test": true
},
{
"os": "macos-12",
"features": "",
"target": "aarch64-apple-ios",
"artifact_name": "ios-arm64-cpu",
"use_cuda": false,
"can_skip_in_simple_test": true
},
{
"os": "macos-12",
"features": "",
"target": "aarch64-apple-ios-sim",
"artifact_name": "ios-arm64-cpu-sim",
"use_cuda": false,
"can_skip_in_simple_test": true
},
{
"os": "macos-12",
"features": "",
"target": "x86_64-apple-ios",
"artifact_name": "ios-x64-cpu",
"use_cuda": false,
"can_skip_in_simple_test": true
}
]'

(↑ whl_local_versionが無いやつ (i.e. iOSとAndroid)はPythonのビルド対象外です)

macos-11なら事前のcargo buildとかが無くても、問題なく一発でmaturin buildできるはずです。将来的に12に引き上げるときはどうなのかというと…そのときまでには問題が解決していることを願うしかないかと。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PyPIで公開する?
3 participants