Maturin, PyO3, pyo3-asyncio, pyo3-logをアップデート #664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qryxip
commented
Oct 27, 2023
This reverts commit 3a5de57.
|
無事CIが通るようになりましたが、ついでにpyo3-logもアップデートします (なんかそのままだと問題が起きそうな気がしたので) |
勘弁してほしい |
Hiroshiba
reviewed
Oct 28, 2023
sevenc-nanashi
approved these changes
Oct 29, 2023
Hiroshiba
approved these changes
Oct 29, 2023
Comment on lines
+283
to
+284
| poetry run -- cargo build -p voicevox_core_python_api -vv || true | ||
| [ -n "$(find ../../target/debug/deps -name 'libopen_jtalk_sys-*.rlib')" ] |
There was a problem hiding this comment.
poetry環境でcargo buildする、なるほどです！！
ちなみに|| trueは失敗することがある感じでしょうか？ 👀
There was a problem hiding this comment.
失敗の例としては、これですね。
#664 (comment)
open_jtal-sysのビルド(= Maturinの外でcargo buildする目的)はできますがdylibのリンクには失敗します。そしてdylibのリンクまでは不要です (何故ならそっちはそもそもMaturinがやるべきなので)
There was a problem hiding this comment.
へーーーなるほどです。
リンクに失敗するのも不思議感ありました。とりあえずビルドは進みきりそうなので。
ちなみに将来問題が起きたときのためにお聞きしておきたいのですが、maturinがopen_jtalk-sysのビルドに失敗する（open_jtalkのdylibのリンクに失敗する）のは、何が原因っぽい感じなんでしょう 👀
理由はわからないけどmaturinがmacos-12でビルド後のリンク処理に失敗する、みたいな･･･？
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
Maturinを0.13.7から、PyO3/maturin#1811が含まれている1.3.1に上げます。
(追記) pyo3, pyo3-asyncio, pyo3-logもアップデートします。
関連 Issue
その他
CC: @tuna2134