-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Maturin, PyO3, pyo3-asyncio, pyo3-logをアップデート #664
Merged
Merged
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
61730d8
Maturinをv1.3.1に
qryxip 3a5de57
voicevox_core_c_apiを先にビルドしてみる
qryxip 818e5f7
Revert "voicevox_core_c_apiを先にビルドしてみる"
qryxip 724e1c6
PyO3をv0.19.2に
qryxip eca2c1b
間違えて入れたファイルを削除
qryxip 9f82d86
`cargo build`するのはあくまでワークアラウンド扱いとする
qryxip e133286
pyo3-logもv0.9.0に
qryxip a6f6683
インデントずれを修正
qryxip b7e9e10
pyo3-logをv0.9.0からv0.8.3に
qryxip ebe2112
readmeに注意書きを入れる
qryxip f37e4bd
語弊のある表現を修正
qryxip 1c706cc
pyo3-logをv0.8.4からv0.8.3に
qryxip fa8bae5
`dev-dependencies`はあっても問題なし
qryxip 16fd981
pyo3-logを再びv0.9.0に
qryxip 267057f
事前の`cargo build`は、open_jtalk-sysのビルドまでできていればよい
qryxip 6277822
target directoryの位置を修正
qryxip 170676c
readmeに追記
qryxip 197219e
[skip ci] `if`の指定のしかたを他に合わせる
qryxip a46864d
コメントを更新
qryxip 93a7cfd
コメントを更新
qryxip File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
poetry環境でcargo buildする、なるほどです!!
ちなみに
|| true
は失敗することがある感じでしょうか? 👀There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
失敗の例としては、これですね。
#664 (comment)
open_jtal-sysのビルド(= Maturinの外で
cargo build
する目的)はできますがdylibのリンクには失敗します。そしてdylibのリンクまでは不要です (何故ならそっちはそもそもMaturinがやるべきなので)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
へーーーなるほどです。
リンクに失敗するのも不思議感ありました。とりあえずビルドは進みきりそうなので。
ちなみに将来問題が起きたときのためにお聞きしておきたいのですが、maturinがopen_jtalk-sysのビルドに失敗する(open_jtalkのdylibのリンクに失敗する)のは、何が原因っぽい感じなんでしょう 👀
理由はわからないけどmaturinがmacos-12でビルド後のリンク処理に失敗する、みたいな・・・?