Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

日本語などを含むパス上でも実行が可能になったpyopenjtalkを使うようにする #7

Merged

Conversation

yamachu
Copy link
Contributor

@yamachu yamachu commented Aug 8, 2021

ref: https://github.com/Hiroshiba/voicevox/issues/12

再現が可能になったバージョンをrequirements.txtに追記しました。

確認手順は以下の通りです

cd voicevox_engineだよ # 日本語を含めるため適当なパスになっています
python -m venv venv
. venv/Scripts/activate
pip install -r requirements.txt
python run.py

image

https://github.com/Hiroshiba/voicevox_engine/pull/8
の変更を含めた状態で行っています

Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! こちらの環境でも問題なく動作しそうでした。

@Hiroshiba Hiroshiba merged commit 8d4697a into VOICEVOX:master Aug 8, 2021
@yamachu yamachu deleted the use-specified-version-pyopenjtalk branch August 8, 2021 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants