Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIRROR] workspace improvements #12863

Closed
wants to merge 1 commit into from
Closed

[MIRROR] workspace improvements #12863

wants to merge 1 commit into from

Conversation

VirgoBot
Copy link
Collaborator

Original PR: PolarisSS13/Polaris#8583

closes #8554 -- conflicting outcomes


This improves repository health by:

  • Adding a dependabot config to keep action versions and npm targets updated.
  • Updating workflows to ubuntu-latest, instead of bionic.
  • Correcting python files to not have mixed indentation and be 3.Xy.
  • Adding a node script that can be used to identify files with bad UTF-8 contents.
    • This was necessary because python is a sad, weak thing. Destroy snek.

This improves the VSC, DMLS, and alternate editor experience by:

  • Grouping dme, dmf, dmm, dm together as the [dm] language alias.
  • Uniformly applying \r\n and tab indent rules to [dm].
  • Preferring \n line endings for all other file types.
  • Explicitly using utf-8 encoding for all files.
  • Enabling whitespace trimming for all files.
    • Except markdown, which does not trim final newlines for formatting reasons.
  • Enforcing the local 4 space python indent.
  • Enforcing the local 2 space yaml indent.
    • And cleaning up the inconsistently indented autochangelog workflow.
  • Recommending language support, the language server, editorextensions, and gitlens.
  • Adding a .editorextensions file with indent, trimming, etc as close as possible to VSC settings.
    • This permits the use of things like sublime and atom, if they are set up for it.
  • Letting you preview DMI files in VSC (1).
  • Building the type tree for (best effort) alternate source navigation (2).
  • Skipping the task failed abort modal for suite builds that fail.
  • Defaulting suite tick on create and auto update on.

(1):
https://i.imgur.com/EhLAlHW.png

(2):
https://i.imgur.com/DJDHaKb.png

Building the type tree also lets you discover path bugs with your eyes!
https://i.imgur.com/0ak7Ksc.png

@boring-cyborg boring-cyborg bot added the Type: .git or .github Could be dangerous to merge. label Apr 29, 2022
@Very-Soft
Copy link
Contributor

me want to look into this more later

@Very-Soft Very-Soft closed this Jun 24, 2022
@Very-Soft Very-Soft reopened this Jun 24, 2022
@Poojawa Poojawa mentioned this pull request Jul 29, 2022
@Cameron653
Copy link
Contributor

This has been sitting and has a lot of conflicts. Highly suggest to port this over later.

I won't close this because of it's importance, but this should be fixed ASAP.

@Heroman3003
Copy link
Contributor

I don't really get this but it seems to be mostly for VSC nerds and if you say this is important, I'll leave this hanging.

@Heroman3003
Copy link
Contributor

This is usalvagable by now, I imagine?

@Heroman3003
Copy link
Contributor

I'll just say that if this is wanted, people are free to request a reopen on this, but until then, to the bin it goes.

@ItsSelis ItsSelis deleted the upstream-merge-8583 branch February 9, 2024 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants