Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

s and S Key Commands Not Working #3274

Closed
currenthandle opened this issue Dec 18, 2018 · 7 comments
Closed

s and S Key Commands Not Working #3274

currenthandle opened this issue Dec 18, 2018 · 7 comments
Labels
status/needs-more-info

Comments

@currenthandle
Copy link

in command mode the s and S key commands don't do anything. I expect that when I press s in command mode, the character under my cursor should be deleted and then I should be in insert mode at the cursor location. But currently it's not doing anything.

https://stackoverflow.com/questions/53821721/vs-code-vim-plugin-in-command-mode-the-s-and-s-key-commands-dont-do-anything
@jpoon
Copy link
Member

jpoon commented Dec 29, 2018

Can't repro. These are most definitely supported commands: https://github.com/VSCodeVim/Vim/blob/master/src/actions/commands/actions.ts#L2345.

@jpoon
Copy link
Member

jpoon commented Dec 30, 2018

Closing this issue, but feel free to re-open if I am mistaken from my above comment.

@jpoon jpoon closed this as completed Dec 30, 2018
@ELLIOTTCABLE
Copy link

For anybody else running across this — I accidentally enabled the vim.sneak option when I first installed VSCode-Vim; make sure you didn't too!

Set "vim.sneak": false in your settings.json.

@currenthandle
Copy link
Author

@ELLIOTTCABLE THANK YOU!

@rethab
Copy link

rethab commented Mar 2, 2020

Ran into this as well, because I just copied the default config from the README. As I suspect that most people don't use sneak, I think it might make sense to not include that in the example.

WDYT @jpoon ? I'd be happy to draft a PR.

@jpoon
Copy link
Member

jpoon commented Mar 3, 2020

Feel free to create a PR @rethab

rethab added a commit to rethab/Vim that referenced this issue Mar 4, 2020
@rethab
readme: remove sneak from quick example
4d81804 
  * many people seem to copy the 'quick example' from the readme as
    their initial config. The problem with that quick example is that it
    enables 'sneak', which by defaults breaks the S and s commands (see
    issue VSCodeVim#3274).

  * by removing that setting from the example, people should have a
    working config out of the box. If someone is interested in sneak,
    other sections of the readme still go into details.
@rethab rethab mentioned this issue Mar 4, 2020
Merged
@rethab
Copy link

rethab commented Mar 4, 2020

@jpoon : #4619

jpoon added a commit that referenced this issue Mar 5, 2020
@jpoon
readme: remove sneak from quick example (#4619)
fc0089a 
* many people seem to copy the 'quick example' from the readme as
    their initial config. The problem with that quick example is that it
    enables 'sneak', which by defaults breaks the S and s commands (see
    issue #3274).

  * by removing that setting from the example, people should have a
    working config out of the box. If someone is interested in sneak,
    other sections of the readme still go into details.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status/needs-more-info
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@ELLIOTTCABLE @jpoon @rethab @currenthandle