Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: remove outdated notes on splits from roadmap #3564

Merged
merged 2 commits into from Mar 9, 2019

Conversation

jkillian
Copy link
Contributor

@jkillian jkillian commented Mar 8, 2019

What this PR does / why we need it:
Removes some outdated notes from the roadmap about VSCode window limitations that were no longer new.

@TravisBuddy
Copy link

Travis tests have failed

Hey @jkillian,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

Node.js: 8

View build log

if [[ $(git diff-index HEAD -- *.js *.ts *.md) ]]; then git diff; echo "Prettier Failed. Run `gulp forceprettier` and commit changes to resolve."; exit 1; fi
diff --git a/ROADMAP.md b/ROADMAP.md
index d2152cd..ae982fa 100644
--- a/ROADMAP.md
+++ b/ROADMAP.md
@@ -439,8 +439,8 @@ Miscellanea:
 | :white_check_mark:        | :1234: @@                         | repeat previous @{a-z} (N times)                                                                   |
 | :arrow_down:              | :@{a-z}                           | execute the contents of register {a-z} as an Ex command                                            |
 | :arrow_down:              | :@@                               | repeat previous :@{a-z}                                                                            |
-| :arrow_down:              | :[range]g[lobal]/{pattern}/[cmd]  | execute Ex command [cmd](default: ":p") on the lines within [range] where {pattern} matches        |
-| :arrow_down:              | :[range]g[lobal]!/{pattern}/[cmd] | execute Ex command [cmd](default: ":p") on the lines within [range] where {pattern} does NOT match |
+| :arrow_down:              | :[range]g[lobal]/{pattern}/[cmd]  | execute Ex command [cmd](default: ':p') on the lines within [range] where {pattern} matches        |
+| :arrow_down:              | :[range]g[lobal]!/{pattern}/[cmd] | execute Ex command [cmd](default: ':p') on the lines within [range] where {pattern} does NOT match |
 | :arrow_down:              | :so[urce] {file}                  | read Ex commands from {file}                                                                       |
 | :arrow_down:              | :so[urce]! {file}                 | read Vim commands from {file}                                                                      |
 | :arrow_down:              | :sl[eep][sec]                     | don't do anything for [sec] seconds                                                                |
diff --git a/test/configuration/validators/neovimValidator.test.ts b/test/configuration/validators/neovimValidator.test.ts
index c898e10..7785632 100644
--- a/test/configuration/validators/neovimValidator.test.ts
+++ b/test/configuration/validators/neovimValidator.test.ts
@@ -33,4 +33,4 @@ suite('Neovim Validator', () => {
     // assert
     assert.equal(actual.numErrors, 0);
   });
-});
\ No newline at end of file
+});
diff --git a/test/state/vimState.test.ts b/test/state/vimState.test.ts
index 51c32a2..193640d 100644
--- a/test/state/vimState.test.ts
+++ b/test/state/vimState.test.ts
@@ -17,10 +17,7 @@ suite('VimState', () => {
     const vimState = new VimState(vscode.window.activeTextEditor!);
     const cursorStart = new Position(0, 0);
     const cursorStop = new Position(0, 1);
-    const initialCursors = [
-      new Range(cursorStart, cursorStop),
-      new Range(cursorStart, cursorStop)
-    ];
+    const initialCursors = [new Range(cursorStart, cursorStop), new Range(cursorStart, cursorStop)];
 
     // test
     vimState.cursors = initialCursors;
@@ -36,7 +33,7 @@ suite('VimState', () => {
     const cursorStop = new Position(0, 1);
     const initialCursors = [
       new Range(cursorStart, cursorStop),
-      new Range(new Position(1, 0), new Position(1, 1))
+      new Range(new Position(1, 0), new Position(1, 1)),
     ];
 
     // test
Prettier Failed. Run [05:37:12] Using gulpfile ~/build/VSCodeVim/Vim/gulpfile.js
[05:37:12] Starting 'forceprettier'...
[05:37:25] Finished 'forceprettier' after 14 s and commit changes to resolve.
TravisBuddy Request Identifier: 41a358f0-4164-11e9-b4f6-c1bea236eaae

@TravisBuddy
Copy link

Travis tests have failed

Hey @jkillian,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

Node.js: 8

View build log

if [[ $(git diff-index HEAD -- *.js *.ts *.md) ]]; then git diff; echo "Prettier Failed. Run `gulp forceprettier` and commit changes to resolve."; exit 1; fi
diff --git a/ROADMAP.md b/ROADMAP.md
index d2152cd..ae982fa 100644
--- a/ROADMAP.md
+++ b/ROADMAP.md
@@ -439,8 +439,8 @@ Miscellanea:
 | :white_check_mark:        | :1234: @@                         | repeat previous @{a-z} (N times)                                                                   |
 | :arrow_down:              | :@{a-z}                           | execute the contents of register {a-z} as an Ex command                                            |
 | :arrow_down:              | :@@                               | repeat previous :@{a-z}                                                                            |
-| :arrow_down:              | :[range]g[lobal]/{pattern}/[cmd]  | execute Ex command [cmd](default: ":p") on the lines within [range] where {pattern} matches        |
-| :arrow_down:              | :[range]g[lobal]!/{pattern}/[cmd] | execute Ex command [cmd](default: ":p") on the lines within [range] where {pattern} does NOT match |
+| :arrow_down:              | :[range]g[lobal]/{pattern}/[cmd]  | execute Ex command [cmd](default: ':p') on the lines within [range] where {pattern} matches        |
+| :arrow_down:              | :[range]g[lobal]!/{pattern}/[cmd] | execute Ex command [cmd](default: ':p') on the lines within [range] where {pattern} does NOT match |
 | :arrow_down:              | :so[urce] {file}                  | read Ex commands from {file}                                                                       |
 | :arrow_down:              | :so[urce]! {file}                 | read Vim commands from {file}                                                                      |
 | :arrow_down:              | :sl[eep][sec]                     | don't do anything for [sec] seconds                                                                |
diff --git a/test/configuration/validators/neovimValidator.test.ts b/test/configuration/validators/neovimValidator.test.ts
index c898e10..7785632 100644
--- a/test/configuration/validators/neovimValidator.test.ts
+++ b/test/configuration/validators/neovimValidator.test.ts
@@ -33,4 +33,4 @@ suite('Neovim Validator', () => {
     // assert
     assert.equal(actual.numErrors, 0);
   });
-});
\ No newline at end of file
+});
diff --git a/test/state/vimState.test.ts b/test/state/vimState.test.ts
index 51c32a2..193640d 100644
--- a/test/state/vimState.test.ts
+++ b/test/state/vimState.test.ts
@@ -17,10 +17,7 @@ suite('VimState', () => {
     const vimState = new VimState(vscode.window.activeTextEditor!);
     const cursorStart = new Position(0, 0);
     const cursorStop = new Position(0, 1);
-    const initialCursors = [
-      new Range(cursorStart, cursorStop),
-      new Range(cursorStart, cursorStop)
-    ];
+    const initialCursors = [new Range(cursorStart, cursorStop), new Range(cursorStart, cursorStop)];
 
     // test
     vimState.cursors = initialCursors;
@@ -36,7 +33,7 @@ suite('VimState', () => {
     const cursorStop = new Position(0, 1);
     const initialCursors = [
       new Range(cursorStart, cursorStop),
-      new Range(new Position(1, 0), new Position(1, 1))
+      new Range(new Position(1, 0), new Position(1, 1)),
     ];
 
     // test
Prettier Failed. Run [05:37:37] Using gulpfile ~/build/VSCodeVim/Vim/gulpfile.js
[05:37:37] Starting 'forceprettier'...
[05:37:51] Finished 'forceprettier' after 14 s and commit changes to resolve.
TravisBuddy Request Identifier: 50ef5cf0-4164-11e9-b4f6-c1bea236eaae

new Range(cursorStart, cursorStop),
new Range(cursorStart, cursorStop)
];
const initialCursors = [new Range(cursorStart, cursorStop), new Range(cursorStart, cursorStop)];
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gulp forceprettier seems to have made a few unrelated changes, I left them in since it seemed harmless

@jpoon
Copy link
Member

jpoon commented Mar 9, 2019

Thanks @jkillian

@jpoon jpoon merged commit 078e575 into VSCodeVim:master Mar 9, 2019
@TravisBuddy
Copy link

Hey @jkillian,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 7870d570-41fe-11e9-b594-dbf9d598ca9b

@jkillian jkillian deleted the roadmap_notes branch March 9, 2019 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants