Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: remove outdated notes on splits from roadmap #3564

Merged
merged 2 commits into from
Mar 9, 2019
Merged

docs: remove outdated notes on splits from roadmap #3564

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
81ba1f2
docs: remove outdated notes on splits from roadmap
jkillian Mar 8, 2019
f11c587
Merge branch 'master' into roadmap_notes
jpoon Mar 9, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 4 additions & 4 deletions ROADMAP.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -524,10 +524,10 @@ Since the list is too long, now we just put those already supported options here
| ------------------------- | ----------------- | ----------------------------------------------------------------------- | ---------------------------------------------------------------------------------------------------------------------- |
| :white_check_mark: :star: | :e[dit] {file} | Edit {file}. | We will open file in a new Tab of current Grouped Editor instead of opening in current tab. |
| :white_check_mark: :star: | <ctrl-w> hl | Switching between windows. | As we don't have the concept of Window in VS Code, we are mapping these commands to switching between Grouped Editors. |
| :white_check_mark: | :sp {file} | Split current window in two. | VS Code doesn't support split Window horizontally. |
| :white_check_mark: :star: | :vsp {file} | Split vertically current window in two. | VS Code only supports three vertical window at most and that's the limitation of this command. |
| :white_check_mark: | :new | Create a new window horizontally and start editing an empty file in it. | VS Code doesn't support split Window horizontally. |
| :white_check_mark: :star: | :vne[w] | Create a new window vertically and start editing an empty file in it. | VS Code only supports three vertical window at most and that's the limitation of this command. |
| :white_check_mark: | :sp {file} | Split current window in two. | |
| :white_check_mark: :star: | :vsp {file} | Split vertically current window in two. | |
| :white_check_mark: | :new | Create a new window horizontally and start editing an empty file in it. | |
| :white_check_mark: :star: | :vne[w] | Create a new window vertically and start editing an empty file in it. | |

## Tabs

Expand Down
2 changes: 1 addition & 1 deletion test/configuration/validators/neovimValidator.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,4 +33,4 @@ suite('Neovim Validator', () => {
// assert
assert.equal(actual.numErrors, 0);
});
});
});
7 changes: 2 additions & 5 deletions test/state/vimState.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,7 @@ suite('VimState', () => {
const vimState = new VimState(vscode.window.activeTextEditor!);
const cursorStart = new Position(0, 0);
const cursorStop = new Position(0, 1);
const initialCursors = [
new Range(cursorStart, cursorStop),
new Range(cursorStart, cursorStop)
];
const initialCursors = [new Range(cursorStart, cursorStop), new Range(cursorStart, cursorStop)];
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gulp forceprettier seems to have made a few unrelated changes, I left them in since it seemed harmless


// test
vimState.cursors = initialCursors;
Expand All @@ -36,7 +33,7 @@ suite('VimState', () => {
const cursorStop = new Position(0, 1);
const initialCursors = [
new Range(cursorStart, cursorStop),
new Range(new Position(1, 0), new Position(1, 1))
new Range(new Position(1, 0), new Position(1, 1)),
];

// test
Expand Down