New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make ReplaceWithRegister work in visual mode #4016
Conversation
f5ca18f
to
56982c2
Compare
Travis tests have failedHey @stevenguh, Node.js: 8if [[ $(git diff-index HEAD -- *.js *.ts *.md) ]]; then git diff; echo "Prettier Failed. Run `gulp forceprettier` and commit changes to resolve."; exit 1; fi
TravisBuddy Request Identifier: b8f22a30-ca30-11e9-a673-e3b5aa05dde7 |
Travis tests have failedHey @stevenguh, Node.js: 8if [[ $(git diff-index HEAD -- *.js *.ts *.md) ]]; then git diff; echo "Prettier Failed. Run `gulp forceprettier` and commit changes to resolve."; exit 1; fi
TravisBuddy Request Identifier: f34ecee0-ca30-11e9-a673-e3b5aa05dde7 |
56982c2
to
9537885
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, other than the nit regarding the README
What this PR does / why we need it:
This fixes the issue where ReplaceWithRegister doesn't work in visual mode
Which issue(s) this PR fixes
#4015