Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Anyway to automatically upgrade VSCodium with system setup on Windows? #411

Closed
playgithub opened this issue Jun 7, 2020 · 27 comments
Closed

Comments

@playgithub
Copy link

playgithub commented Jun 7, 2020

Now I have to check github periodically to see if there is a new version.

@Lonniebiz
Copy link

Lonniebiz commented Jun 7, 2020

Well, you can automate that too :) Sorry, I just discovered this project moments ago. So, hi.

@stripedpajamas
Copy link
Member

Auto updates should work out of the box. We run a small server (https://GitHub.com/VSCodium/update-api) that VSCodium calls to check for the latest release on GitHub.

Have you noticed that updates are not working? If so can you provide some more context about what version, OS, etc you're running?

@playgithub
Copy link
Author

It's greate.
I'll take care for the next update.
Thanks

@Lierrmm
Copy link

Lierrmm commented Jun 8, 2020

Just to add on to this;

When requesting an update from Windows 10 1909 the update-api returns a 404 status with no further information.
I have provided an image below of the notification if it helps at all.

This is on version 1.45.1 of VSCodium.

image

@playgithub
Copy link
Author

VSCdoium 1.45.1
Windows 10
Check for Updates, shows:
image

@stripedpajamas
Copy link
Member

@Lierrmm can you provide OS + arch + type of installation (archive, system, user)?

I just poked the API with the various combinations and look good. I suspect MS may have changed the way in which they call the Update API for some specific combination.

https://vscodium.now.sh/api/update/win32-x64-system/stable/asdf
https://vscodium.now.sh/api/update/win32-x64-user/stable/asdf
https://vscodium.now.sh/api/update/win32-x64-archive/stable/asdf
https://vscodium.now.sh/api/update/win32-ia32-system/stable/asdf
https://vscodium.now.sh/api/update/win32-ia32-user/stable/asdf
https://vscodium.now.sh/api/update/win32-ia32-archive/stable/asdf

@Lierrmm
Copy link

Lierrmm commented Jun 9, 2020

win32-x64-system was the version of VSCodium I installed.

System Details from winver: Windows 10 Pro 1909 Build: 18363.836

@alex-quiniou
Copy link

alex-quiniou commented Jun 9, 2020

I have the same issue

Version: 1.45.1 (system setup)
Commit: 5763d909d5f12fe19f215cbfdd29a91c0fa9208a
Date: 2020-05-15T10:23:54.161Z
Electron: 7.2.4
Chrome: 78.0.3904.130
Node.js: 12.8.1
V8: 7.8.279.23-electron.0
OS: Windows_NT x64 10.0.18363

Capture

I use the install x64 version : VSCodiumSetup-x64-1.45.1

@stripedpajamas
Copy link
Member

Based on this code snippet, I think the issue is that MS is no longer sending "-system" up for x64 system install.

As far as I can tell (pls check my work!), the platform combinations should hit the following urls (asdf is the "commit" portion of the url):

arch installer url
x64 system /api/update/win32-x64/stable/asdf
x64 user /api/update/win32-x64-user/stable/asdf
x64 archive /api/update/win32-x64-archive/stable/asdf
ia32 system /api/update/win32/stable/asdf
ia32 user /api/update/win32-user/stable/asdf
ia32 archive /api/update/win32-archive/stable/asdf

The fix should be fairly trivial change in https://github.com/VSCodium/update-api (PRs welcome; I'll work on it if I have a free hour to focus).

@GitMensch
Copy link
Collaborator

Just a related note- auto-updates via package managers (of this and a multitude of other software) is a general option, too (works fine for me on Trisquel GNU/Linux, should work fine on other systems, too as long as you use the available package managers - see https://vscodium.com/#install).
I'd still like to see the win32-x64 updates working, too.

@playgithub
Copy link
Author

From 1.45.1 to 1.46.0, it seems working, it shows downloading in the menu.
Because of my network environment the download speed is at 0.1MB/s.
However it works.

@GitMensch
Copy link
Collaborator

Didn't work for me with:

Version: 1.46.0 (system setup)
Commit: a5d1cc28bb5da32ec67e86cc50f84c67cc690321
Date: 2020-06-12T10:32:02.515Z
Electron: 7.3.1
Chrome: 78.0.3904.130
Node.js: 12.8.1
V8: 7.8.279.23-electron.0
OS: Windows_NT x64 10.0.19041

Still getting a 404 error.
Reopen?

@playgithub Does it work for you? Do you also use a x64 version?

@playgithub playgithub reopened this Jun 19, 2020
@playgithub
Copy link
Author

It shows downloading as Menu/Help/Dowloading Update...
It's very slow, it'll take hours to download.
Tested for about 5 minutes, not error message.
Also checked the log, no error.

Version: 1.46.0 (user setup)
Commit: a5d1cc28bb5da32ec67e86cc50f84c67cc690321
Date: 2020-06-12T10:32:02.515Z
Electron: 7.3.1
Chrome: 78.0.3904.130
Node.js: 12.8.1
V8: 7.8.279.23-electron.0
OS: Windows_NT x64 10.0.18363

@GitMensch
Copy link
Collaborator

Rechecked, that is what my log says:

[2020-06-19 15:21:11.109] [main] [info] update#setState idle
[2020-06-19 15:21:23.528] [main] [info] update#setState checking for updates
[2020-06-19 15:21:23.757] [main] [error] Error: Server returned 404
at t.asJson (C:\Program Files\VSCodium\resources\app\out\vs\code\electron-main\main.js:374:953)
at processTicksAndRejections (internal/process/task_queues.js:85:5)
[2020-06-19 15:21:23.757] [main] [info] update#setState idle
[2020-06-19 15:21:41.121] [main] [info] update#setState checking for updates
[2020-06-19 15:21:41.308] [main] [error] Error: Server returned 404
at t.asJson (C:\Program Files\VSCodium\resources\app\out\vs\code\electron-main\main.js:374:953)
at processTicksAndRejections (internal/process/task_queues.js:85:5)
[2020-06-19 15:21:41.308] [main] [info] update#setState idle

Is there a way to log more details?

@playgithub
Copy link
Author

[2020-06-19 20:46:23.787] [main] [info] update#setState idle
[2020-06-19 20:46:28.025] [main] [info] update#setState checking for updates
[2020-06-19 20:46:29.578] [main] [info] update#setState downloading

@GitMensch
Copy link
Collaborator

@playgithub Do you have a 32bit or 64bit version of VSCodium? [if not100% sure: open it, open it, then open taskmanager->details, right click on the columns, choose "platform" and have a look]
In my case it is a 64bit version of VSCodium and the previous discussion here hinted that only those are broken.

@playgithub
Copy link
Author

playgithub commented Jun 19, 2020

x86 64bit

@playgithub
Copy link
Author

With a proxy, successfully updated from 1.46.0 to 1.46.1
vscodium 1.46.0 x64 on Windows 10 pro x64

@GitMensch
Copy link
Collaborator

So do the people that get a 404 need to configure a proxy? If yes how?
Note: all extensions can be installed and updated via VSCodium fine, the only thing that never worked so far was the integrated update...

@playgithub
Copy link
Author

playgithub commented Jun 20, 2020

On Windows, shadowsocks client will set the proxy in system level automatically, vscodium use that automatically.

@Heptazhou
Copy link

I believe the problem is still with *-system cases.

@playgithub Update does work in a user setup but not in a system setup.

It shows downloading as Menu/Help/Dowloading Update...
It's very slow, it'll take hours to download.
Tested for about 5 minutes, not error message.
Also checked the log, no error.

Version: 1.46.0 (user setup)
Commit: a5d1cc28bb5da32ec67e86cc50f84c67cc690321
Date: 2020-06-12T10:32:02.515Z
Electron: 7.3.1
Chrome: 78.0.3904.130
Node.js: 12.8.1
V8: 7.8.279.23-electron.0
OS: Windows_NT x64 10.0.18363

@Heptazhou
Copy link

@stripedpajamas I wonder if you have time to take a look at VSCodium/update-api#5, see whether it meets #411 (comment).

@playgithub playgithub reopened this Jun 21, 2020
@changemenemo
Copy link

So I've searched for hours now if it was my pihole or nextdns filter but it seems not. I still have 404 error.
X64 system windows 10
general setup not user setup.
Did you succeed to make some changes about the update process or not at all?

@GitMensch
Copy link
Collaborator

@boistordu The current state is "works with user setup, doesn't with system setup".
That's the reason this issue is kept open. But I do suggest to rename it to make that clear - @playgithub can you please do this?

@playgithub playgithub changed the title Anyway to upgrade VSCodium automatically? Anyway to automatically upgrade VSCodium with system setup on Windows? Jul 13, 2020
@playgithub
Copy link
Author

of cause, edited

@stripedpajamas
Copy link
Member

stripedpajamas commented Jul 13, 2020

Thanks to @Heptazhou for the PR; https://vscodium.now.sh/api/update/win32-x64/stable/asdf now returns an update blob. Can the people who have Windows x64 system setup see if the auto update is working? If you've already updated to latest version, you at least shouldn't get a 404 anymore. The responses from the update API for valid inputs are 200 (update available), and 201 (no update available).

@GitMensch
Copy link
Collaborator

Update worked like a charm (the only issue is that the temporary installer has no code-certificate at all, but that looks like already been handled by #174). I think this can be closed now.
Note: I guess the new issue tracked at #447 just come in "naturally", not by the update procedure.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants