Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated "unity-launch" flag from Linux desktop files #1866

Merged
merged 1 commit into from
May 6, 2024
Merged

Remove deprecated "unity-launch" flag from Linux desktop files #1866

merged 1 commit into from
May 6, 2024

Conversation

xalt7x
Copy link
Contributor

@xalt7x xalt7x commented May 6, 2024

Upstream deprecated and removed "unity-launch" flag.
This commit removes this redundant flag from Linux desktop files since it breaks file opening from the outside.

Closes #1865

@daiyam daiyam merged commit f93746b into VSCodium:master May 6, 2024
20 checks passed
@daiyam
Copy link
Member

daiyam commented May 6, 2024

@xalt7x Thanks for the catch!

ryderwishart added a commit to BiblioNexus-Foundation/codex that referenced this pull request May 22, 2024
commit 268ecff
Author: ryderwishart <ryderwishart@gmail.com>
Date:   Tue May 21 16:26:40 2024 -0700

    Rebrand to Codex; modify build scripts and automated workflows

    # Conflicts:
    #	patches/brand.patch

commit 02a9d03
Author: VSCodium CI <vscodium-ci@not-real.com>
Date:   Thu May 9 18:12:33 2024 +0000

    build(stable): update to commit dc96b83

commit f93746b
Author: Yevhen Popok <xalt7x.service@gmail.com>
Date:   Mon May 6 17:08:01 2024 +0300

    fix(linux): deprecate unity-launch flag (VSCodium#1866)

commit 0d28b4d
Author: Baptiste Augrain <daiyam@zokugun.org>
Date:   Sun May 5 10:55:17 2024 +0200

    feat(1.89): update patches (VSCodium#1863)

commit 39df447
Author: Lex <115115137+lex-ibm@users.noreply.github.com>
Date:   Fri Apr 26 01:59:33 2024 -0500

    feat: use sysroot for PPC64LE (VSCodium#1857)
ryderwishart added a commit to BiblioNexus-Foundation/codex that referenced this pull request May 22, 2024
commit c6dbefa
Author: ryderwishart <ryderwishart@gmail.com>
Date:   Wed May 22 02:05:44 2024 -0700

    Update GitHub workflows for stable builds

commit 268ecff
Author: ryderwishart <ryderwishart@gmail.com>
Date:   Tue May 21 16:26:40 2024 -0700

    Rebrand to Codex; modify build scripts and automated workflows

    # Conflicts:
    #	patches/brand.patch

commit 02a9d03
Author: VSCodium CI <vscodium-ci@not-real.com>
Date:   Thu May 9 18:12:33 2024 +0000

    build(stable): update to commit dc96b83

commit f93746b
Author: Yevhen Popok <xalt7x.service@gmail.com>
Date:   Mon May 6 17:08:01 2024 +0300

    fix(linux): deprecate unity-launch flag (VSCodium#1866)

commit 0d28b4d
Author: Baptiste Augrain <daiyam@zokugun.org>
Date:   Sun May 5 10:55:17 2024 +0200

    feat(1.89): update patches (VSCodium#1863)

commit 39df447
Author: Lex <115115137+lex-ibm@users.noreply.github.com>
Date:   Fri Apr 26 01:59:33 2024 -0500

    feat: use sysroot for PPC64LE (VSCodium#1857)
@wtechgo
Copy link

wtechgo commented Jun 3, 2024

I'm on KDE Plasma 6 Manjaro fully updated and I still have this issue.

@daiyam
Copy link
Member

daiyam commented Jun 3, 2024

@wtechgo Yes, the AUR vscodium-bin doesn't have the fix since I can't push it (not co-maintainer on this one). I've emailed the maintainer but did get any answer (Just realized that I've sent him the wrong issue, sending another one).

@wtechgo
Copy link

wtechgo commented Jun 7, 2024

@wtechgo Yes, the AUR vscodium-bin doesn't have the fix since I can't push it (not co-maintainer on this one). I've emailed the maintainer but did get any answer (Just realized that I've sent him the wrong issue, sending another one).

It's indeed vscodium-bin on my system. Thanks for sending the issue again.

@wtechgo
Copy link

wtechgo commented Jun 8, 2024

I just updated Manjaro, VScodium 1.90.0 came through and the issue is fixed.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"--unity-launch" flag in Linux desktop file breaks file opening from the outside
3 participants