-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Radar - bomb position, adjust icon size #129
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice one :)
I've two things:
- Use
None
instead of some magic values to indicate that the bomb info is not available - May extend the info send along for the bomb info similar to what the overlay does.
This allows later on to easily extend the UI :)
|
||
#[derive(Serialize, Deserialize, Clone, Debug)] | ||
#[serde(rename_all = "camelCase")] | ||
pub struct RadarBombInfo { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe add a flag whatever it's planted or not.
Maybe use a similar system as I've done here including the bomb state: https://github.com/Valthrun/Valthrun/blob/master/controller/src/enhancements/bomb.rs#L51
In your case it would be RadarBombInfo containing the position and the C4State which may includes Dropped, Carried
as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added more data into RadarBombInfo. You can check it out.
204e2cb
to
1a05da3
Compare
Hey, I've merged manually your changes |
Bomb position is now shown on the radar.
Added drawer where is slider for setting of icon size.