Remove gevent monkeypatching. #287
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For somebody using this package as a library, it would be preferable to leave whether to monkeypatch gevent into the standard library up to the user, rather than forcing it on every consumer. As far as I can tell, the only place that monkeypatching is used, is for interacting with requests. The only place this is *directly* used by the client is in `steam.core.CMClient.boostrap_from_webapi`, which is only called on the initial connection. Letting that call be synchronous, if the user doesn't want to use gevent directly seems reasonable.
|
You are correct. I've been intending to remove monkey patch to make the code easier to use in conjunction with other libraries and features of python. That webapi call, and another webapi method, are the only places where library might need it. Of course the user could be using |
|
This will also affect |
|
Is it possible to re-run checks on this and look to merge? Would greatly benefit codebase |
tomwade
reviewed
Jan 13, 2021
|
|
||
| ### steam.client | ||
|
|
||
| - Importing `steam.client` no longer automatically patches `socket or `ssl` to |
|
I very much want this to happen, but I need to:
|
|
Closing in favour of #364 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For somebody using this package as a library, it would be preferable to leave
whether to monkeypatch gevent into the standard library up to the user, rather
than forcing it on every consumer.
As far as I can tell, the only place that monkeypatching is used, is for
interacting with requests. The only place this is directly used by
the client is in
steam.core.CMClient.boostrap_from_webapi, which isonly called on the initial connection. Letting that call be synchronous,
if the user doesn't want to use gevent directly seems reasonable.