-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added DuplicateOrderedDict #6
Conversation
If we are to ship this we need to implement all the methods from https://docs.python.org/3/library/stdtypes.html#mapping-types-dict Should be compatible with py2 and py3. For example, in py3 All that with the order/duplicates in mind, of course. At a glance it seems that it might not be the case currently. May as well consider calling it Finally, might as well throw the code for it in a separate file as this is |
I refactored the code a bit. It should now be compatible with py2 and 3. edit: We should def squash my fail series if you accept this pull request. (Sorry for the mess) |
Hi, I've pulled your code and reworked it. See #8 |
I added your DuplicateOrderedDict implementation as referenced in #5 , and some test cases.
Also, i made the usage feel a bit more like a "real" dict.
If you don't like my changes please tell me what to change.
IMHO, the vdf lib really need something like this build in asap.