Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added javascript deck code encoder and parser #10

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

NorthFury
Copy link

I don't know if you want to extend this utility for other languages as well but here is my take on a javascript version.

I worked on this because I found it to be a nice little challenge. After seeing the monetization strategy for Artifact, it is very unlikely I'll buy the game. As such, I don't know if I'll follow up with further PRs.

Potential improvements:

  • the encoder may be extended with a few more validations
  • the encoder is lacking the name sanitizing
  • there are limitations to what characters are allowed for the name

PS: I'm not a JS dev. That being said I'm quite happy with how this turned out. One could argue that the encoder and decoder are good candidates to be written as classes but they're more than fine as they are.

@NorthFury
Copy link
Author

I forgot to mention, there is only one dependency to base64-js. This should allow the code to run both on node servers and client side.

@kaflan
Copy link

kaflan commented Nov 15, 2018

@NorthFury Hi. How to use your code to serve side and build api or Open Graph api buld.
I am front end dev, little backend i can to send to you email letter about this?

@NorthFury
Copy link
Author

@kaflan you can copy the code in your project for now. If nobody reacts to this PR I'll create a stand alone repo and try to publish it. I'll have some time to look into it next week-end.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants