-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Linux] Item names do not show #16
Comments
All sets are the same. Any inscribed item is simply called "Inscribed." |
You look to be missing the localized names. Can you verify your local file cache? |
I have the same issue and verifying the local file cache didn't fix it. Item and gem's descriptions have the same problem as well. |
I tried validating cache, it said everything validated, and names are still On Tue, Jun 23, 2015, 12:12 Drew Bliss notifications@github.com wrote:
|
the console also has the same issue, |
For me, the close button is just a "r" |
Can you post your console output from starting the game? |
Here is mine :
|
The ILocalize::AddFile errors are why the localized text is not available. I believe the issue is that they are in 'resource' and not 'Resource'. That's not an issue on Windows but needs to be fixed for Linux. |
Just to double-check, if you look at your Reborn files on disk these files (valve_english.txt, gameui_english.txt, etc.) should be in the Reborn folder under game/dota_imported/resource. Are they there? |
The casing is a red-herring, that'll get fixed up, so it seems like you may be missing some files. |
I can find all the files that fail to load in /game/dota_imported/resource (and /game/core/resource for vgui_english.txt). |
That's very strange, I'm not sure why the files wouldn't load if they're present. What filesystem is in use where your games files are? If you have time to waste I'd recommend removing Reborn and doing a fresh install but I have no idea if that would help or not. |
File system is ext4. I can try a re-install over the week-end. |
I can try a reinstall today, and post terminal output when it is installed On Thu, Jun 25, 2015, 13:57 Mael Rouxel-Labbé notifications@github.com
|
I can't seem to copy the terminal output fro some reason, but the output seems very similar to MaeIRL's, including the files that cannot be found. My fliesystem is also ext4. I believe that ext4 is case sensitive, which may be the issue. |
The game will end up using the correct case so I don't think that's the issue. You are still having the problem after removing Reborn entirely and reinstalling? |
Yes. I tried changing the case of the resource folders to Resource as shown in the terminal and restarting the game, but that did nothing so I changed it back. Im going to validate the cache to see if that fixes anything. Should those files have the names of items in them? |
items_english.txt has most of the item strings. In theory validating and reinstalling should have no effect since you do have the files on disk, but as there's no reason why they wouldn't get opened the investigation is kind of stuck. If you have anything out of the ordinary, such as symlinks / NAS / wormoles, that might bear on the problem please let us know. |
Renaming the folders for the correct casing (and restarting Steam/Dota) seems to actually do the trick for me. I had tried earlier but a small issue is that resource/dota_english.txt and Resource/items_english.txt are requested (despite being in the same folder) so it didn't work as one was always missing, but I've now just duplicated the folder to have both options and almost everything loads nicely : only very few item descriptions are still missing (for example for Abbadon's Tarnhelm of Ruin, it still says #DOTA_item_desc_etc.). |
Casing appears to be the issue. Setting both "game/dota_imported/resource" and "/game/core/resource" to the correct(?) casing seems to fix the issue for me. I could not find an item in my armory that has a missing English description. |
Adding folders with Resource instead of resource in the locations specified by computerquip has fixed the issue for me as well as far as I can see. |
That's good that you've pinned it down but it does leave a mystery as to why the case correction isn't working for you. The game fixes up the case normally (otherwise everybody running on a case-sensitive filename would have the same issue) and for some reason that doesn't work for you guys. There aren't a lot of ways that it can fail. Do you have long paths to where the files are? |
Fair point. This is the full path of the folder: "/storage-ssd/SteamLibrary/SteamApps/common/dota 2 beta/game/dota_imported/resource" storage-ssd is an ext3 filesystem statically mounted from a separate harddrive. It is manually added to any Steam environment I setup after Steam is installed. Aside from that, not sure what it could be. |
Your path isn't long so that isn't the issue. However, I wonder if it's the other uppercase letters. There's a fallback in the case correction that just stomps everything to lowercase and that will clearly fail for you. Looking over the code I see some ways that it would reach that point so I believe that could explain it. Fixing it shouldn't be a problem. |
SteamApps should actually be steamapps now that I think about it. There However, by the sound of it, any other capital letter would also be
|
Is there anyway to differentiate between files being used for reborn and files for normal dota? I thought with reborn being so different it would be a completely new folder in SteamApps/common/, but apparently this is not the case. It looks like generally the game is using a lower case r for resource: Searching for the two mentioned files reveals the following: This solved the problem, so yes you found the issue. Also suddenly my hotkey for openging/closing the console works again. I have no idea why not finding localization files would affect the hotkey.. |
There's a whole bunch of code developed on Windows where case didn't matter so it may not have the right case. |
I am aware of that, but I would assume your design document would specify whether it is supposed to be Resource or resource? |
Unfortunately it's not that simple. resource is the correct case but it at one point it was Resource and there's still code from that era. Simple mistakes don't get caught either because either way it works on Windows. |
Well, I guess the important thing that we found the issue. |
Largely history. Things should gradually improve but the current duplication is small and so not a high priority. There's also an override system so files of the same name can be in multiple places but they'll have different content. |
I thought this was an isolated case unfortunately. For what it's worth, I fixed SteamApps to be steamapps again and it did not work. In this case, if it's still stomping SteamLibrary to lower case, it's definitely a bug since that folder should be able to be named anything. |
Yesterday's patch has fixed most of the include failures except for :
Consequently, item names do show up! The previous issue I reported with some item descriptions is still happening though, but these descriptions do not exist in items_english.txt (for example, there's no line for |
I see that one in items_english.txt. Do you have any of these? The file should be something like 12,350 lines.
|
My file is actually above 14k lines, but you misunderstood my post : the name is showing perfectly, the issue is that if the item has no description (which happens for example for that Abaddon's item; you can check on source 1 or wikis, the item has no description), the game prints the variable name It's an issue that it slightly different than the rest of the thread so maybe I should have created a new issue, sorry. |
This looks like the same issue, although the patch appears to have fixed item names. Your descriptions are still messed up though. |
But it's not the same cause. For example, the items_english.txt for source 1 doesn't have an entry for |
Ah, sorry I missed the name vs. description part. This happens on all platforms and I've sent it over the larger team. It won't be tracked here. |
I don't recall this issue on Windows. Have a pic:
This happens with all items.
The text was updated successfully, but these errors were encountered: