-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Zenity: Use GTK3 version instead of GTK4 and LibAdwaita #1534
Comments
@TiZ-HugLife, could you attach a screenshot of the unthemed window? |
fwiw we're mostly trying to not use zenity for anything moving forward |
Yes, that is correct.
Regardless of theming, hard-coding sizes for windows is a pretty terrible idea, because all it takes is a font change, or a localisation change, and you'll get a broken output.
This should only happen in the game session, where there are no portals; the desktop session has the settings portal, and that comes with the color scheme key; make sure that either the xdg-desktop-portal-kde and/or the xdg-desktop-portal-gtk are installed. You'll still get the GNOME default theme instead of Breeze, but it will have both light and dark variants.
If the goal is to maximise use of the Breeze theme, then yes: building zenity from the
There's no "assertion of dominance" in play, here, so please: don't ascribe malicious intent to the GNOME project, which is not involved in what software is shipped on SteamOS. |
Your system information
Please describe your issue in as much detail as possible:
It looks like Zenity in SteamOS 3.6 is using LibAdwaita, which means that it does not use the Breeze GTK theme, and all of its proportions are super out of whack. There are a lot of scripts that hard-code a size for the Zenity dialog, such as the Decky installer, and because LibAdwaita's proportions are so huge, you pretty much can't actually read the dialog anymore. What's more, SteamOS 3.6 ships with a dark theme, and despite all the effort to plumb light/dark theme settings into various parts of the desktop interoperability stacks, LibAdwaita-based Zenity uses the light theme.
Zenity should be replaced with zenity-gtk3 in order to maintain script compatibility and desktop cohesion. Desktop-agnostic script dialogs are no place for GNOME to assert their dominance. I am not sure if it is possible to compile Zenity without LibAdwaita, but Breeze does have a good GTK4 theme, and that could be a potential alternative.
Steps for reproducing this issue:
The text was updated successfully, but these errors were encountered: