Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] PS4/DS4 Controller spams 'X' (cross) and sometimes a navigational direction after connecting #513

Open
Enigma0 opened this issue Apr 22, 2016 · 12 comments

Comments

@Enigma0
Copy link

Enigma0 commented Apr 22, 2016

Your system information

  • Steam client version: latest public brewmaster
  • SteamOS version: latest public brewmaster
  • Opted into Steam client beta?: Yes
  • Opted into SteamOS beta?: No (probably - not sure where to find that information)
  • Have you checked for updates in Settings > System?: Yes - should be running latest

Please describe your issue in as much detail as possible:

Happens with pretty high regularity. Happened last three times I booted SteamOS and turned on controller.

  • Sometimes after turning on the PS4 controller high frequency 'a'/'x' (cross) pushes start occurring that cannot be stopped. Results in a whole bunch of mayhem and usually a game launch.

In order to 'fix' it, I need to hold the PS button until the controller turns off which always results in the glitch automatically launching into Desktop.

Steps for reproducing this issue:

  1. Plug in USB Bluetooth 4.0+ dongle
  2. Pair PS4 controller
  3. Navigate around/hit a few buttons
  4. Turn off controller & turn on controller and repeat step 3
  • May need to turn off controller after paring and then turn it back on
  • May need to restart SteamOS and then turn on after pairing
  • Once it's been powered on and the glitch hasn't occurred (or after playing in a game for a while) it doesn't seem to occur any longer until the next time it's connected.
@Enigma0 Enigma0 changed the title PS4/DS4 Controller spams 'X' (cross) and sometimes a navigational direction after connecting [BUG] PS4/DS4 Controller spams 'X' (cross) and sometimes a navigational direction after connecting May 2, 2016
@SoulEst
Copy link

SoulEst commented May 29, 2016

Unfortunately, this is the issue with having DualShock 4 controllers connected via Bluetooth. I have yet to find a solution to it so I have them connected via USB for now.

@Enigma0
Copy link
Author

Enigma0 commented May 31, 2016

Seems like an issue that could be easily resolved in the Bluetooth stack. If the hardware is not defective, and is in fact not actually sending out button spams, then it is a mis-identification of the incoming Bluetooth data.

Mayflash will be making a PS4 controller dongle like their PS3 controller dongle in several months.

@SoulEst
Copy link

SoulEst commented May 31, 2016

The issue is twofold as you not only have the bluetooth stack, but the kernel driver as well. I will test a 4.5 or 4.6 kernel and let you know the outcome.

@Enigma0
Copy link
Author

Enigma0 commented May 31, 2016

I'd be willing to look at code as well but have 0 experience with this sort of environment. Can't make heads or tails of where any relevant source code may be... I mean it looks like none of it is even hosted on github for starters.

@SoulEst
Copy link

SoulEst commented Jun 1, 2016

Have a look here: https://git.kernel.org/cgit/linux/kernel/git/stable/linux-stable.git/log/?id=refs/tags/v4.5.5 and search for dualshock. The relevant file is at drivers/hid/hid-sony.c. I've compared the driver in the stable kernel (4.5.x) with the driver in the SteamOS kernel (4.1.x) and have found a large difference between the two (over 400 lines of code added for 4.5.5). Here are the hid-sony.c file for Linux 4.1 (SteamOS), Linux 4.5.5 (Stable), and a diff that shows the two files side by side.
hid-sony-diff.zip

@Enigma0
Copy link
Author

Enigma0 commented Jun 1, 2016

So I did do some testing in Ubuntu GNOME 15.10 (and maybe 16.04 can't remember) and noticed the same issues with the bluetooth controller so I'd wager the problems are still there in 4.5.x.

@Tele42
Copy link

Tele42 commented Jun 1, 2016

This issue needs to be fixed upstream before a patch can be proposed to improve the situation on SteamOS.

@ELLIOTTCABLE
Copy link

ELLIOTTCABLE commented Jun 9, 2016

As a data-point, this exact same issue happens to me with a DualShock 4 in standard Big Picture Mode on OS X. I do not believe this issue to be localized to the SteamOS bluetooth stack, or to the tenfoot display-mode.

(I've been back-and-forth with Steam support about it a few times, with no resolution.)

@Enigma0
Copy link
Author

Enigma0 commented Jun 9, 2016

Well IIRC OS X also uses Linux kernels (probably modified) so basically that just helps confirm it's an issue across Linux kernels which I think was already known since the same issue happens in other Debian distros as it is.

Hence Tele42's comment about this issue needing to be fixed upstream. Basically my report here is kind of pointless >.>

@ELLIOTTCABLE
Copy link

n…no, OS X does not use any part of the Linux kernel, much less the
Bluetooth stack. (Darwin microkernel, and eeeeentirely custom / unrelated
network stack)

That's why I brought it up: I don't see the repeated-cross /
repeated-directional-left-and-up behaviour outside of Steam Big Picture
mode; so it follows that it's not reproduced in the system-level Bluetooth
drivers; it's almost certainly specific to Steam, no?
On Thu, Jun 9, 2016 at 9:05 AM Enigma notifications@github.com wrote:

Well IIRC OS X also uses Linux kernels (probably modified) so basically
that just helps confirm it's an issue across Linux kernels which I think
was already known since the same issue happens in other Debian distros as
it is.

Hence Tele42's comment about this issue needing to be fixed upstream.
Basically my report here is kind of pointless >.>


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#513 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AAAAyDyiVrVMQB9fxX_5jCgC-smJ9IOJks5qKB20gaJpZM4INvMj
.

@Enigma0
Copy link
Author

Enigma0 commented Jun 9, 2016

Interesting... Didn't consider that it wasn't an issue after getting into a game but I don't think I've seen this issue in game either. Just in BPM.

So ya my bad. I think your right about that.

@cptn-cosmo
Copy link

I have the same issue as well unfortunately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants