Add configurable mouse sensitivity #915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dlanis
reviewed
Aug 29, 2023
|
Why not just use |
The `--mouse-sensitivity`/`-s` command line option allows the user to set the value `g_mouseSensitivity` which is used to scale the mouse movement in `wlserver_mousemotion`.
|
Okay, I've changed the implementation. I'm not sure how you want to move things around in order to call into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
--mouse-sensitivity/-scommand line option allows the user to set the valueg_mouseSensitivitywhich is used to scale the mouse movement inwlserver_mousemotion.This works well for reducing sensitivity: sub-pixel increments taken into account to avoid jerky cursor movement as a result of rounding.
However, increasing sensitivity results in a loss of precision proportional to the multiplier since it seems mouse movements are only ever given in terms of pixels (i.e. a multiplier of
2.0causes 2 pixels to be the shortest distance the cursor can be moved. If there is a way to get around this, please let me know).This change is a possible workaround for #196 and #244, but the main motivation is to allow forcing mouse sensitivity scaling on games that don't respect the host mouse settings or otherwise misbehave with respect to cursor speed.