m_rawinput changes take no effect if weapon prediction is disabled

[SamVanheer]

Changing the m_rawinput cvar doesn't change the raw input behavior if the cl_lw cvar is 0.

This is because the input code checks the current time using gpGlobals->time:

halflife/cl_dll/inputw32.cpp

Lines 366 to 370 in c7240b9

	if ( gpGlobals && gpGlobals->time - s_flRawInputUpdateTime > 1.0f )
	{
	s_flRawInputUpdateTime = gpGlobals->time;
	m_bRawInput = CVAR_GET_FLOAT( "m_rawinput" ) != 0;
	}

Which is only updated if weapon prediction is enabled:

halflife/cl_dll/hl/hl_weapons.cpp

Lines 680 to 681 in c7240b9

	// Get current clock
	gpGlobals->time = time;

To fix this the input code should get the current time from the engine and use that instead:

const float currentTime = gEngfuncs.GetClientTime();

if ((currentTime - s_flRawInputUpdateTime) > 1.0f || s_flRawInputUpdateTime == 0.0f)
{
	s_flRawInputUpdateTime = currentTime;
	m_bRawInput = CVAR_GET_FLOAT("m_rawinput") != 0;
}

This global variable declaration can also be removed:

halflife/cl_dll/inputw32.cpp

Line 61 in c7240b9

extern globalvars_t *gpGlobals;

Note that because the weapon prediction code sets the time to what's passed in from the engine the time can sometimes be that of an older frame being run again, so the value will be in the past. This doesn't break anything but it could delay the change taking effect by a frame. See #3252 for a change related to that.

[SamVanheer]

This fix is made obsolete by the fix for #3255 which removes the need to check for the current time altogether.