func_rot_button with 'Starts locked' spawn flag not working on map spawn. #401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
November 3, 2015 11:17
Fixed: - "Could not load library client." when launching the mod. - Scene files not playing. - In-game menu. - Gameinfo.txt now has correct parameters Tweaks: - light.rad for glowing textures as seen in maps such as ks_mop_pita1, ks_mop_pita2. Changes: - Map ks_mop_pita1 Increased height of trigger responsible for launching the door blast sequence. Due to a level design error, this event would not occur since the strider's bounding volume would not touch it. - Map ks_mop_pita3 Added extra output to trigger relays to continue through teleport sequence. This is used to overcome a particulars bugs where track pathers entities would fail to reach their destinations, thus not reaching their final destination, which are responsible for triggering future event relays.
This reverts commit 01d4e64.
Added conditional spawn flag to check if SF_BUTTON_LOCKED is set.
malortie
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since CRotButton::Spawn does not call it's base class spawn method, the spawnflag SF_BUTTON_LOCKED condition is never verified.
Once we add the missing conditional statement, the button starts locked, and remains unusable until InputUnlock is called:
Map makers can still overcome this issue by calling Lock on map spawn, but I would recommend fixing instead this problem by adding the modified code provided in this pull request.