ensure PlayArea vertices are consistent - fixes #25 #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `vertices` variable in `SteamVR_PlayArea` is inconsistent when setting the size between Calibrated and a fixed size. The points of the vertices are in different locations based on whether the size is either Calibrated or a given size which causes issues when attempting to use the `vertices` variable to generate play area representations. The solution is to ensure the points of the fixed size match the positions that a calibrated play area also has.
thestonefox
changed the title
|
Integrated, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
verticesvariable inSteamVR_PlayAreais inconsistent whensetting the size between Calibrated and a fixed size.
The points of the vertices are in different locations based on whether
the size is either Calibrated or a given size which causes issues when
attempting to use the
verticesvariable to generate play arearepresentations.
The solution is to ensure the points of the fixed size match the
positions that a calibrated play area also has.