OD-1528: use end-of-day rates #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MPishpecki
approved these changes
Oct 18, 2021
|
One of the tests is failing, I'll fix it before proposing it to the OCA. |
pankk
force-pushed
the
OD-1528/currency_rate_update_oxr/end-of-day
branch
from
0f3d54d
to
bb7f6da
Compare
|
Test fixed. The issue was that on my local the company's currency is set to EUR by default (on a database that Odoo creates when running tests with a database name that doesn't exist yet), while the OCA defaults to USD. I haven't looked at how this default gets determined, but the change to the test here allows for both to work. A future improvement is to make it "default currency agnostic". |
astirpe
approved these changes
Oct 19, 2021
currency_rate_update_oxr/models/res_currency_rate_provider_OXR.py
Outdated
Show resolved
Hide resolved
|
Please don't delete this branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://vmbikes.atlassian.net/browse/OD-1528
Upstream PR: OCA#114