Skip to content

Commit

Permalink
Merge PR OCA#2075 into 12.0
Browse files Browse the repository at this point in the history
Signed-off-by dreispt
  • Loading branch information
OCA-git-bot committed May 8, 2021
2 parents 25cb00f + 5cf8220 commit 72127aa
Showing 1 changed file with 10 additions and 7 deletions.
17 changes: 10 additions & 7 deletions onchange_helper/models/base.py
Original file line number Diff line number Diff line change
Expand Up @@ -51,15 +51,18 @@ def play_onchanges(self, values, onchange_fields):
else:
# We get default values, they may be used in onchange
record_values = self.default_get(self._fields.keys())
for field in self._fields:
if field not in all_values:
all_values[field] = record_values.get(field, False)

for fn, field in self._fields.items():
if not field.related and fn not in all_values: # related fields are False
all_values[fn] = record_values.get(fn, False)

new_values = {}
for field in onchange_fields:
onchange_values = self.onchange(all_values, field, onchange_specs)
new_values.update(self._get_new_values(values, onchange_values))
all_values.update(new_values)
with self.env.do_in_onchange(): # avoid cache issues with related fields!
new = self.new(all_values)
for field in onchange_fields:
onchange_values = new.onchange(all_values, field, onchange_specs)
new_values.update(self._get_new_values(values, onchange_values))
all_values.update(new_values)

return {
f: v
Expand Down

0 comments on commit 72127aa

Please sign in to comment.